[api] Initial API deprecations for Ray 1.0#10325
Merged
ericl merged 40 commits intoray-project:masterfrom Aug 28, 2020
Merged
Conversation
ericl
assigned
pcmoritz,
robertnishihara,
raulchen,
richardliaw,
edoakes,
rkooo567 and
stephanie-wang
rkooo567
reviewed
Aug 25, 2020
stephanie-wang
approved these changes
Aug 25, 2020
ericl
commented
Aug 25, 2020
| assert call.request_args[0] in runner_shard_keys[i] | ||
|
|
||
|
|
||
| # TODO(fix) |
Contributor
Author
Contributor
There was a problem hiding this comment.
I'll remove it ASAP. on it
6 tasks
edoakes
approved these changes
Aug 26, 2020
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
The catharsis is real! We should publish a summary of all of the breaking changes that are being made when we release 1.0.
Contributor
|
I just realized that |
stephanie-wang
added
the
@author-action-required
Contributor
Author
|
Looks like just 1 tune test failed; merging to unblock followup prs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Initial set of API changes for Ray 1.0, focusing on the core Ray APIs. Some of these parameter removals are breaking changes, but none of them should be particularly impactful.
Planning spreadsheet:
https://docs.google.com/spreadsheets/d/1F6VZ1R_fgDzpRZjXI5_6gaUwW2CQKi431dCDTR-Vm8s/edit#gid=0