Skip to content

Fix Issue #10319 - Dashboard autoscaler crash #10323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkooo567 merged 2 commits into from
Aug 30, 2020
Merged

Fix Issue #10319 - Dashboard autoscaler crash #10323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
446c1aa
Patch error that occurred when there was an entry in the dashboard lo…
Aug 25, 2020
81ed170
lint
Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions python/ray/dashboard/node_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,22 @@ def __init__(self, redis_address, redis_password=None):
def _insert_log_counts(self):
for ip, logs_by_pid in self._logs.items():
hostname = self._ip_to_hostname[ip]
logs_by_pid = {pid: len(logs) for pid, logs in logs_by_pid.items()}
self._node_stats[hostname]["log_count"] = logs_by_pid
if hostname in self._node_stats:
logs_by_pid = {
pid: len(logs)
for pid, logs in logs_by_pid.items()
}
self._node_stats[hostname]["log_count"] = logs_by_pid

def _insert_error_counts(self):
for ip, errs_by_pid in self._errors.items():
hostname = self._ip_to_hostname[ip]
errs_by_pid = {pid: len(errs) for pid, errs in errs_by_pid.items()}
self._node_stats[hostname]["error_count"] = errs_by_pid
if hostname in self._node_stats:
errs_by_pid = {
pid: len(errs)
for pid, errs in errs_by_pid.items()
}
self._node_stats[hostname]["error_count"] = errs_by_pid

def _purge_outdated_stats(self):
def current(then, now):
Expand Down