Fix Issue #10319 - Dashboard autoscaler crash#10323
Merged
rkooo567 merged 2 commits intoray-project:masterfrom Aug 30, 2020
Merged
Fix Issue #10319 - Dashboard autoscaler crash#10323rkooo567 merged 2 commits intoray-project:masterfrom
rkooo567 merged 2 commits intoray-project:masterfrom
Conversation
added 2 commits
August 25, 2020 11:16
…gs or errors internal data structures, and a worker was removed from the cluster. This would crash the cluster with a KeyError.
mfitton
added
bug
Contributor
|
Any way to add tests for this? (maybe using cluster_utils)? Do you think it is not worth it because we will move onto the new backend? |
rkooo567
approved these changes
Aug 25, 2020
rkooo567
added
the
@author-action-required
Contributor
|
@mfitton I will just merge it because we will turn on the new dashboard very soon. But please write the test scenario for this case and add it to the new dashboard in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Please view the issue for more details. #10319
Related issue number
Closes #10319
Checks
scripts/format.shto lint the changes in this PR.