-
Notifications
You must be signed in to change notification settings - Fork 670
[history server] Add initial version of event server for history server. #4253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: chiayi [email protected] Co-authored-by: KunWuLuan [email protected]
|
Manually tested using @KunWuLuan 's historyserver and collector. Assuming that the events are stored in Running the eventserver will read these files and turn them into task objects. I've also temporary replaced the historyserver endpoint and function getTaskDetail() to return the unformatted list of tasks. Running |
| logrus.Infof("Event processor received stop signal, exiting.") | ||
| return | ||
| default: | ||
| // S3, minio, and GCS are flat structures, object names are whole paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anything we'd need to do to ensure hygiene for azure blob storage originating data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no, for more details about object's path, you can refer the design doc here
https://github.com/ray-project/enhancements/blob/main/reps/2025-11-21-ray-history-server/2025-11-21-ray-history-server.md#file-structure-for-persisted-events--logs
|
Thanks for the PR! I think the high level approach looks good! Some a bit detailed comment:
I'll wait for more polished version of the PR to do more detailed review. |
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's some field we can't get from ray event, should we get it from log dir?
for example, get the task field profiling_data from
{session_dir}/logs/export_events/event_EXPORT_TASK.log
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, can you show me step by step how to test this PR in local env using kind?
It will be very helpful for me if you can show how where the event processor call Run and get data from the object storage.
for example, it would be helpful if there's a guide like this.
|
Co-authored-by: @chiayi [email protected]
Co-authored-by: @KunWuLuan [email protected]
Why are these changes needed?
This PR adds the event server part of history server that constructs tasks/actors from ray events.
Related issue number
Related to #3884
Checks