Conversation
|
@KunWuLuan thanks for the PR, can you share any steps to follow to test the changes? |
KunWuLuan
force-pushed
the
historyserver-beta
branch
29 times, most recently
from
1cc3c68 to
1b989db
Compare
KunWuLuan
force-pushed
the
historyserver-beta
branch
8 times, most recently
from
3e1df23 to
7462b93
Compare
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
probably need a README like this to test it locally https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md
thank you!
|
@KunWuLuan can we split this PR into smaller ones? Maybe one PR for event collector, another for logging collector and one for history server? |
There was a problem hiding this comment.
Hi, I did these changes in my local diff.txt
and this work in my local.
- build the history server and load it to kind
kind create cluster --image=kindest/node:v1.24.0
# start the kuberay operator
cd historyserver
make localimage
docker tag historyserver:latest rayproject/historyserver:latest
kind load docker-image rayproject/historyserver:latest- create minio, service account, history server, and ray cluster
kubectl apply -f minio.yaml
kubectl apply -f sa.yaml
kubectl apply -f raycluster.yaml
kubectl apply -f historyserver.yaml- Accessing HistoryServer
kubectl port-forward svc/historyserver 8080:30080
open http://localhost:8080/#/overview
- Accessing Minio Console
kubectl port-forward svc/minio-service -n minio-dev 9001:9001
open http://localhost:9001/browser
# account: minioadmin
# password: minioadmin
KunWuLuan
force-pushed
the
historyserver-beta
branch
from
9cc0cab to
c193555
Compare
|
@andrewsykim @Future-Outlier Hi, I have splitted the PRs into small ones. I will check the CI tests this week. You can help to review the code. Thank you very much. |
Hi @KunWuLuan , do you have the links to those smaller PRs? |
KunWuLuan
force-pushed
the
historyserver-beta
branch
from
3f81b05 to
25efc02
Compare
update go.work go.mod Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
KunWuLuan
force-pushed
the
historyserver-beta
branch
from
25efc02 to
ae7a7fd
Compare
| flag.StringVar(&rayRootDir, "ray-root-dir", "", "") | ||
| flag.StringVar(&kubeconfigs, "kubeconfigs", "", "") | ||
| flag.StringVar(&dashboardDir, "dashboard-dir", "/dashboard", "") | ||
| flag.StringVar(&runtimeClassConfigPath, "runtime-class-config-path", "", "") //"/var/collector-config/data" |
There was a problem hiding this comment.
nit: can keep the default value here, in the third arg.
| kubeconfigs := "" | ||
| runtimeClassConfigPath := "/var/collector-config/data" | ||
| dashboardDir := "" | ||
| flag.StringVar(&runtimeClassName, "runtime-class-name", "", "") |
There was a problem hiding this comment.
Hi, @sb-hakunamatata this is just POC, plz review other PRs.
4 participants
Why are these changes needed?
Related issue number
Checks