Skip to content

Revert "Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility"#4031

Merged
kevin85421 merged 1 commit intomasterfrom
revert-4029-upgrade-crd-ref-docs
Sep 2, 2025
Merged

Revert "Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility"#4031
kevin85421 merged 1 commit intomasterfrom
revert-4029-upgrade-crd-ref-docs

Conversation

@Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 2, 2025

Reverts #4029, since we have to support go 1.24.6 first, then we can bump crd-ref-docs to v0.2.0

go 1.24.0

Copy link
Contributor

@seanlaii seanlaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this! Sorry for any inconvenience.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why KubeRay CI didn't catch the issue before #4029 was merged?

@kevin85421 kevin85421 merged commit c30fae2 into master Sep 2, 2025
26 checks passed
@seanlaii
Copy link
Contributor

seanlaii commented Sep 2, 2025

Why KubeRay CI didn't catch the issue before #4029 was merged?

It is because the CI is using 1.24.6: https://github.com/ray-project/kuberay/actions/runs/17391243377/job/49365277103.

@seanlaii
Copy link
Contributor

seanlaii commented Sep 2, 2025

To match the CI version, should we also upgrade Go version to 1.24.6, which includes some security fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants