Skip to content

Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rueian merged 1 commit into from
Sep 2, 2025
Merged

Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility #4029

rueian merged 1 commit into from
Sep 2, 2025

Conversation

@seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Sep 2, 2025 •
edited
Loading

Why are these changes needed?

The current version (v0.0.12) depends on golang.org/x/[email protected], which causes build failures under newer Go toolchains (e.g., Go 1.24+). Example error:

$ go version                          
go version go1.25.0 darwin/arm64

$ make api-docs
# golang.org/x/tools/internal/tokeninternal
.../golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
make: *** [crd-ref-docs] Error 1

Upgrading to v0.2.0 provides compatibility with modern Go versions (1.24+) and aligns this project with the latest maintained release of crd-ref-docs.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@seanlaii
Copy link
Contributor Author

seanlaii commented Sep 2, 2025

/retest

Future-Outlier
Future-Outlier approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @seanlaii

@rueian rueian merged commit 3858146 into ray-project:master Sep 2, 2025
31 of 32 checks passed
Future-Outlier added a commit that referenced this pull request Sep 2, 2025
@Future-Outlier
Revert "Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility (#4029)"
e540884 
This reverts commit 3858146.
@Future-Outlier Future-Outlier mentioned this pull request Sep 2, 2025
Merged
kevin85421 pushed a commit that referenced this pull request Sep 2, 2025
@Future-Outlier
Revert "Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility (#4029)…
c30fae2 
…" (#4031)
@seanlaii seanlaii deleted the upgrade-crd-ref-docs branch September 2, 2025 03:46
win5923 pushed a commit to win5923/kuberay that referenced this pull request Sep 4, 2025
@seanlaii @win5923
Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility (ray-project#4029
ae9cd59 
)

Signed-off-by: wei-chenglai <[email protected]>
win5923 pushed a commit to win5923/kuberay that referenced this pull request Sep 4, 2025
@Future-Outlier @win5923
Revert "Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility (ray-p…
682680a 
…roject#4029)" (ray-project#4031)
@JiangJiaWei1103 JiangJiaWei1103 mentioned this pull request Dec 14, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rueian rueian rueian approved these changes

@Future-Outlier Future-Outlier Future-Outlier approved these changes

@owenowenisme owenowenisme owenowenisme approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seanlaii @rueian @Future-Outlier @owenowenisme