Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jacobian and partial inconsistencies for nurbs basis #52

Merged
merged 28 commits into from
Jun 18, 2024

Conversation

rath3t
Copy link
Owner

@rath3t rath3t commented Jun 18, 2024

No description provided.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 72.23506% with 841 lines in your changes missing coverage. Please review.

Project coverage is 77.53%. Comparing base (3b7f7f5) to head (0bbb6a0).
Report is 1 commits behind head on main.

Files Patch % Lines
dune/iga/trim/nurbstrimmer.hh 0.00% 391 Missing ⚠️
dune/iga/trim/subgridhelpers.hh 0.00% 89 Missing ⚠️
dune/iga/nurbspatch.hh 81.60% 71 Missing ⚠️
dune/iga/trim/subgrid.hh 0.00% 44 Missing ⚠️
dune/iga/trim/nurbstrimboundary.hh 0.00% 35 Missing ⚠️
dune/iga/io/ibra/ibrageometry.hh 0.00% 34 Missing ⚠️
dune/iga/utils/fillquadraturerule.hh 0.00% 23 Missing ⚠️
dune/iga/geometry/geohelper.hh 45.94% 20 Missing ⚠️
dune/iga/test/gridtests.cpp 84.87% 18 Missing ⚠️
dune/iga/nurbsleafgridview.hh 73.84% 17 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   78.04%   77.53%   -0.52%     
==========================================
  Files          31       31              
  Lines        3913     4060     +147     
==========================================
+ Hits         3054     3148      +94     
- Misses        859      912      +53     
Flag Coverage Δ
tests 77.53% <72.23%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rath3t rath3t changed the title Update gridtests.cpp Fix jacobian and partial inconsistencies for nurbs basis Jun 18, 2024
@rath3t rath3t enabled auto-merge (squash) June 18, 2024 13:38
@rath3t rath3t force-pushed the fix/partialJacobianInconsistency branch from 1b57376 to 0bbb6a0 Compare June 18, 2024 14:25
@rath3t rath3t disabled auto-merge June 18, 2024 14:37
@rath3t rath3t enabled auto-merge (squash) June 18, 2024 14:37
@rath3t rath3t merged commit 2a66fd2 into main Jun 18, 2024
11 of 13 checks passed
@henrij22 henrij22 deleted the fix/partialJacobianInconsistency branch June 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant