Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters for IntegrationRuleCreator shouldn't be hardcoded #31

Open
Tracked by #50
henrij22 opened this issue Nov 3, 2023 · 1 comment · May be fixed by #51
Open
Tracked by #50

Parameters for IntegrationRuleCreator shouldn't be hardcoded #31

henrij22 opened this issue Nov 3, 2023 · 1 comment · May be fixed by #51

Comments

@henrij22
Copy link
Collaborator

henrij22 commented Nov 3, 2023

As of now the parameter used for creating the subgrids which determine the precisness of geometry approximation are hardcoded in subgrid.hh as follows:

/// Parameters
static constexpr int maxOuterBoundaryDivisions{10};
static constexpr int maxInnerBoundaryDivisions{10};

static constexpr double outerTargetTolerance{1e-4};
static constexpr double innerTargetTolerance{1e-4};

This could be done for example with set default values and the possibility of an input file which overrides these default values.
Maybe add a settings struct that can be passed into the trimmer / subgrid.

It would also be good if at least some of these settings could be changed during run-time and not compile-time.

@henrij22 henrij22 self-assigned this Nov 3, 2023
@henrij22
Copy link
Collaborator Author

henrij22 commented Nov 6, 2023

See also #16 -> define interface

@henrij22 henrij22 removed their assignment Nov 8, 2023
@henrij22 henrij22 changed the title Parameters for subgrid creation shouldn't be hardcoded Parameters for triangulation shouldn't be hardcoded Nov 29, 2023
@henrij22 henrij22 changed the title Parameters for triangulation shouldn't be hardcoded Parameters for IntegrationRuleCreator shouldn't be hardcoded Nov 29, 2023
@henrij22 henrij22 linked a pull request Jun 18, 2024 that will close this issue
@henrij22 henrij22 linked a pull request Jun 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant