Rolling ToDo List for PR #46

[henrij22]

This is meant to keep track of unfinished buisiness. These points don't have to be adressed before merging #46

• IbraReader should check first if file exists #47
• How to handle preferences and parameters for trimming (Integration rule parameters are currently transferred via a singelton object)
• check implementation of TrimmedReferenceElement
• think about IndexSet, currently index for elements is unique, but should be independent index Set for trimmed and full, this will break the basis implementation atm
• Ensure that boundarySegmentIndex is consecutive for trimmed patches
• Enable checkBoundarySegment test, either its not correctly implemented or the test fails because its not suited for none-reference elements
• Check implementation of

auto secondFundamentalForm(const LocalCoordinate& local) const {
      return patchGeometry_->secondFundamentalForm(local);
    }

    auto zeroFirstAndSecondDerivativeOfPosition(const LocalCoordinate& local) const {
      return patchGeometry_->zeroFirstAndSecondDerivativeOfPosition(local);
    }

• Reimplement correct hash function for IdType

template <typename HostIdType>
struct std::hash<Dune::IGANEW::DefaultTrim::IdType<HostIdType>>
{
  std::size_t operator()(const Dune::IGANEW::DefaultTrim::IdType<HostIdType>& k) const 

• The line

  dune-iga/dune/iga/nurbsbasis.hh

  Line 666 in 6cb633b

  in, patchData_.knotSpans, patchData_.degree, extractWeights(patchData_.controlPoints), 1, false,

  was changed to

  dune-iga/dune/iga/nurbsbasis.hh

  Lines 700 to 702 in 3c55b2f

  	const auto dN = IGANEW::Splines::Nurbs<dim, ScalarType>::basisFunctionDerivatives(
  	in, patchData_.knotSpans, patchData_.degree, IGANEW::Splines::extractWeights(patchData_.controlPoints), 1,
  	currentKnotSpan);

  (getting rid of the false) ⚠️ this function doens't seem to be ever tested or compiled in our testing suite

Backlog

• Sanitise nurbsPatchData input #3

FIxed

• Parameters for IntegrationRuleCreator shouldn't be hardcoded #31
• test volume function for trimmed elements in geometrylocalView
• globalRefine crashes when called with a value greater 1
• implement volume() methods for trimmed geometries
• Refactor trimmed Geometry<griddim> to be constructable from a FieldVector
• center() method is currently invoked via DefaultGeometryImplementation where global(0.5) is called which doesn't make sense for trimmed geometries
• test center method