Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/deps #113

Merged
merged 5 commits into from
Nov 21, 2021
Merged

Chore/deps #113

merged 5 commits into from
Nov 21, 2021

Conversation

escapedcat
Copy link
Collaborator

test, tsc, build working

@cstenglein
Copy link
Collaborator

Thank you 👍

About the typescript dependency: I'm not sure if we should update it now, since it could work, but will fail if we use TS >4.3 features (see facebook/create-react-app#11022)

Eagerly waiting for CRA 5, but until then I wouldn't wanna risk it :P

@escapedcat
Copy link
Collaborator Author

About the typescript dependency: I'm not sure if we should update it now, since it could work, but will fail if we use TS >4.3 features (see facebook/create-react-app#11022)

Ah nice, was trying to find the supported version of craco. Is is mentioned in their docs somehwere?
Will switch TS to 4.3.x, ok?

@cstenglein
Copy link
Collaborator

Better leave it at 4.1 :P

craco should work regardless, it's just that newer ts features won't be supported until cra 5

Haven't tested it yet, but I don't think there is anything breaking in it since build & test worked :)

@cstenglein
Copy link
Collaborator

Thx 👍

@cstenglein cstenglein merged commit 0301765 into raspiblitz:master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants