Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.3.5 #11022

Closed
icecream17 opened this issue May 27, 2021 · 5 comments
Closed

Typescript 4.3.5 #11022

icecream17 opened this issue May 27, 2021 · 5 comments

Comments

@icecream17
Copy link

icecream17 commented May 27, 2021

Describe the bug

Typescript just released a new version: 4.3.2 4.3.5

Did you try recovering your dependencies?

N/A

Which terms did you search for in User Guide?

None (was just released June 30th)

Environment

(gitpod since I only have access to an online terminal)

Environment Info:

  current version of create-react-app: 4.0.3
  running from /home/gitpod/.nvm/versions/node/v14.17.0/lib/node_modules/create-react-app

  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (16) x64 Intel(R) Xeon(R) CPU
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.17.0/bin/yarn
    npm: 7.14.0 - ~/.nvm/versions/node/v14.17.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    react: ^17.0.2 => 17.0.2 
    react-dom: ^17.0.2 => 17.0.2 
    react-scripts: 4.0.3 => 4.0.3 
  npmGlobalPackages:
    create-react-app: 4.0.3

Steps to reproduce

(Write your steps here:)

  1. Create a new typescript app
  2. Use the override keyword (see typescript's release notes or the repro below)
  3. Doesn't compile

Expected behavior

Now that I know the new version was just released, this is normal

Actual behavior

Discovered with:
https://github.com/icecream17/solver/runs/2686100874?check_suite_focus=true

Reproducible demo

I don't feel like making a demo so here's more detailed instructions

npx create-react-app example
cd example
npm install --save-prod [email protected]
// Then change App.tsx
class A {
  b(){}
}

class B extends A {
  override b () {}
}
npm test
@mrmckeb
Copy link
Contributor

mrmckeb commented May 31, 2021

This requires us to upgrade to a newer version of Babel.
https://github.com/babel/babel/releases/tag/v7.14.0

We often do this before a release, and I've flagged this for the next minor release - so hopefully we can get this in.

@mrmckeb
Copy link
Contributor

mrmckeb commented May 31, 2021

This may actually already be partly solved by #10797, as you'll be able to upgrade dependencies now.

@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 8, 2021

Just a note on this @icecream17, we're hoping to ship support for this in the next minor release - providing everything else in the chain has been updated.

It looks like typescript-eslint is, which is great. So I'm hopeful :)

@Gilwe
Copy link

Gilwe commented Jun 24, 2021

@mrmckeb Question, when is the next minor version planned to be released?

@icecream17 icecream17 changed the title Typescript 4.3.2 Typescript 4.3.5 Jul 2, 2021
@iansu
Copy link
Contributor

iansu commented Aug 11, 2021

We've released the first alpha of Create React App v5 which should support TypeScript 4.3. If you have any problems please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants