Sync some changes from KvikIO's Array
#290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
improvement
madsbk
reviewed
Sep 30, 2024
wence-
reviewed
Oct 1, 2024
| def __init__(self, obj: object): ... | ||
| T = TypeVar("T") | ||
|
|
||
| class Array(Generic[T]): |
There was a problem hiding this comment.
Same comment here as in ucx-py
There was a problem hiding this comment.
Same answer: rapidsai/ucx-py#1080 (comment)
Edit: Let's keep the discussion in UCX-Py for now. Can follow up here after that resolves
pentschev
requested changes
Oct 1, 2024
Co-authored-by: Peter Andreas Entschev <[email protected]>
pentschev
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
LGTM here too, similar to rapidsai/ucx-py#1080 (review), it's probably good to have @wence- voice his opinion one more time. Thanks @jakirkham .
wence-
approved these changes
Oct 4, 2024
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in a few changes from KvikIO's
Array. Namely...asarrayfor easy conversion toArray(no-op if already anArray)