Sync some changes from KvikIO's Array
#1080
Conversation
jakirkham
added
enhancement
|
|
||
| T = TypeVar("T") | ||
|
|
||
| class Array(Generic[T]): |
There was a problem hiding this comment.
nit: This a slightly weird use of a generic type. Usually one would read a type Array[T] as "an array containing objects of type T", that is for x : Array[T], then x[i] : T forall i \in [0, len(x)). However, here you're using it to mean the wrapped type.
There was a problem hiding this comment.
This is taken from verbatim from KvikIO. Appears this was added in PR ( rapidsai/kvikio#214 ), which it looks like you approved 😉
That said, no objection to changing it to something else. Could you please submit a PR to KvikIO with the syntax you prefer? Can then incorporate it here 🙂
Co-authored-by: Peter Andreas Entschev <[email protected]>
There was a problem hiding this comment.
LGTM in spite of @wence-'s comment, that can probably be addressed in KvikIO first and then again incorporated here but it's probably a good idea to let Lawrence voice his (dis-)approval of that too. Thanks @jakirkham .
Pulls in a few changes from KvikIO's
Array. Namely...asarrayfor easy conversion toArray(no-op if already anArray)