Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conditional in _stream_recv_callback #801

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Fix conditional in _stream_recv_callback #801

merged 1 commit into from
Oct 23, 2021

Conversation

pentschev
Copy link
Member

With #799 I introduced a subtle but highly problematic issue that ironically cancels out the UCXCanceled error in the stream receive callback, this PR fixes that.

@pentschev pentschev requested a review from a team as a code owner October 22, 2021 21:35
@jakirkham
Copy link
Member

jakirkham commented Oct 23, 2021 •
edited
Loading

@gpucibot merge

Edit: Oops forgot that doesn’t work here 😅

@jakirkham jakirkham merged commit 121ad2b into rapidsai:branch-0.23 Oct 23, 2021
@jakirkham
Copy link
Member

Thanks Peter! 😀

@pentschev
Copy link
Member Author

Thanks John for review!

@pentschev pentschev mentioned this pull request Oct 26, 2021
Closed
@pentschev pentschev deleted the fix-stream-recv-callback branch October 28, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @jakirkham