Raise UCXNotConnected on stream receive callback #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasiben
reviewed
Oct 21, 2021
| @@ -113,6 +119,10 @@ cdef void _stream_recv_callback( | |||
| name = req_info["name"] | |||
| msg = "<%s>: " % name | |||
| exception = UCXCanceled(msg) | |||
| if status == UCS_ERR_NOT_CONNECTED: | |||
There was a problem hiding this comment.
Should we add any debug logging here ? If it's intermittent maybe this might help
There was a problem hiding this comment.
I mean the Dask use behavior is intermittent, not the code itself. The problem seems to be that when Dask tries to reconnect this error is raised, but the reconnect process happens once the other end has already closed. The exception can be seen clearly when it happens, and this is what dask/distributed#5449 is catching now, therefore logging doesn't seem to have any use to me now.
quasiben
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue that occurs non-deterministically in Distributed, generally during
client._reconnectat shutdown when peers have already begun closing. Therefore, we need to catch this exception and raiseCommClosedErrorin Distributed to prevent unhandled errors.