Skip to content

build-in-devcontainer: fail if expected devcontainer directories aren't found#487

Merged
jameslamb merged 1 commit intomainfrom
stricter-devcontainer
Jan 8, 2026
Merged

build-in-devcontainer: fail if expected devcontainer directories aren't found#487
jameslamb merged 1 commit intomainfrom
stricter-devcontainer

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 7, 2026

Follow-up from #408 (comment)

As of this PR, if the build-in-devcontainer workflow is called and the calling repo is missing the expected devcontainers directory, it'll fail loudly instead of passing silently.

Notes for Reviewers

The extra flexibility here bit us during rapidsai/build-planning#236. In the first round of PRs there, RAPIDS devcontainer directories were renamed from like cuda13.0-pip to cuda13.1-pip but the corresponding call of this workflow wasn't updated. The devcontainer CI jobs passed in CI and we didn't notice that builds were not actually running.

As of this PR, they'd fail loudly and alert us to that.

@jameslamb jameslamb added breaking Introduces a breaking change improvement Improves an existing functionality labels Jan 7, 2026
@jameslamb jameslamb requested a review from trxcllnt January 7, 2026 19:05
@jameslamb jameslamb changed the title WIP: build-in-devcontainer: fail if expected devcontainer directories aren't found build-in-devcontainer: fail if expected devcontainer directories aren't found Jan 7, 2026
@jameslamb jameslamb marked this pull request as ready for review January 7, 2026 19:05
@jameslamb jameslamb requested a review from a team as a code owner January 7, 2026 19:05
@jameslamb jameslamb requested review from rockhowse and removed request for a team January 7, 2026 19:06
Copy link
Contributor

@rockhowse rockhowse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't 100% fully comprehend the world of devcontainers yet and defer the actually ✅ to someone more knowledgeable like @trxcllnt

Once someone with more devcontainer related 👀 feel free to ping me and I am happy to ✅ as I in-general support fail fast and loud for critical things that were currently failing silently causing confusion and engineering time trying to track down.

@gforsyth
Copy link
Contributor

gforsyth commented Jan 7, 2026

These devcontainer workflows were passing in a newer (private) repo even though there are no devcontainers set up for that repo. These changes would make those workflows fail in that scenario. I think that's fine -- probably best to not add the devcontainer workflow unless you want it to do something.

@jameslamb
Copy link
Member Author

That's my perspective too. The solution for not having devcontainers yet should just be "don't run the devcontainer CI job" just as a repo that only has conda packages wouldn't call any of the wheels workflows.

I think being stricter here is worthwhile.

@jameslamb jameslamb merged commit 030851d into main Jan 8, 2026
2 checks passed
@jameslamb jameslamb deleted the stricter-devcontainer branch January 8, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants