Update CCCL to 3.4.0 pre-release - #996
Merged
Merged
Conversation
bdice
added
improvement
Contributor
Author
|
CCCL-RAPIDS CI is currently failing. There is an issue with the cuML job using Python 3.14, which is fixed by NVIDIA/cccl#8268. That is not required to merge this change. There is a separate issue with the cudf_kafka builds failing to find CCCL, which I am still investigating with the team. This should still be safe to merge, because it seems that the CMake issue only occurs when CCCL is being overridden as observed in the CCCL-RAPIDS CI. Normal builds should be fine. |
vyasr
approved these changes
Apr 2, 2026
Contributor
Author
|
/merge |
3 tasks
rapids-bot Bot
pushed a commit
to NVIDIA/cuml
that referenced
this pull request
Apr 3, 2026
This PR fixes two build issues exposed by recent dependency updates: rapidsai/rapids-cmake#996. It adds the explicit Thrust constant-iterator header needed for randomforest.cuh to compile with CCCL 3.4, where thrust::make_constant_iterator is no longer available through transitive includes. It also updates cuML benchmark registration to match the benchmark@1.9.5 API by passing ownership with std::unique_ptr instead of a raw pointer, which resolves the SG benchmark compile failures. cc @bdice could use an eye in the quick change in `randomforest.cuh` Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Simon Adorf (https://github.com/csadorf) - Divye Gala (https://github.com/divyegala) URL: #7949
rapids-bot Bot
pushed a commit
to NVIDIA/cudf
that referenced
this pull request
Apr 7, 2026
This reverts commit 9f31e1d. Closes #21953. With rapidsai/rapids-cmake#996, the previous bug should be fixed. Authors: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) Approvers: - James Lamb (https://github.com/jameslamb) URL: #21999
shrshi
pushed a commit
to shrshi/cudf
that referenced
this pull request
May 12, 2026
This reverts commit 9f31e1d. Closes NVIDIA#21953. With rapidsai/rapids-cmake#996, the previous bug should be fixed. Authors: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) Approvers: - James Lamb (https://github.com/jameslamb) URL: NVIDIA#21999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates CCCL to 3.4.0 pre-release.
Specific PRs that we need:
kernel_scan_warpNVIDIA/cccl#8236Comparison of CCCL commits: NVIDIA/cccl@33895cb...c5594eb
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))