Skip to content

Update CCCL version - #1008

Merged
rapids-bot[bot] merged 5 commits into
rapidsai:mainfrom
nirandaperera:patch-2
Apr 29, 2026
Merged

Update CCCL version#1008
rapids-bot[bot] merged 5 commits into
rapidsai:mainfrom
nirandaperera:patch-2

Conversation

@nirandaperera

@nirandaperera nirandaperera commented Apr 16, 2026 •
edited by bdice
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updates CCCL to the latest 3.4.0 pre-release commit.

Comparison of CCCL commits: NVIDIA/cccl@c5594eb...a4fd978

We specifically need these features/fixes for RAPIDS projects:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@nirandaperera
Update CCCL version
cf1869a 
Bumping CCCL version to use latest changes in rapidsmpf
@nirandaperera
nirandaperera requested a review from a team as a code owner April 16, 2026 20:47
@nirandaperera
nirandaperera marked this pull request as draft April 16, 2026 21:03
@robertmaynard

robertmaynard commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

We only adopt CCCL release branches, not main.

@bdice
bdice marked this pull request as ready for review April 17, 2026 04:03
@bdice

bdice commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

We only adopt CCCL release branches, not main.

We have been pinned to commits from main for several months, due to needing new features (for the RMM CCCL migration) and fixes (for Blackwell and other bugs) that aren't in release branches. I updated the PR description to reflect the fixes I have been tracking since the last bump in #996.

@bdice bdice assigned bdice and unassigned bdice Apr 17, 2026
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 17, 2026
@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Apr 20, 2026
@bdice

bdice commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

I'd like to wait to merge this until we land the RMM CCCL memory resource migration (starting merges tomorrow). That will come with a number of build breaking changes that are disruptive on their own. We can merge this after that migration settles.

@nirandaperera

nirandaperera commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

@bdice I think so.

@nirandaperera

nirandaperera commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

@bdice I would like to revisit this. I want to use resource_cast utils in rapidsmpf.
https://github.com/NVIDIA/cccl/blob/main/libcudacxx/include/cuda/__memory_resource/any_resource.h#L984
Should we bump the version to CCCL main HEAD?

@nirandaperera
nirandaperera requested a review from bdice April 29, 2026 20:44
@nirandaperera nirandaperera mentioned this pull request Apr 29, 2026
Merged
@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Apr 29, 2026
bdice
bdice approved these changes Apr 29, 2026
View reviewed changes

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is using the latest commit from CCCL that has passed nightly RAPIDS builds. I verified locally that all of RAPIDS builds with this commit, and that cuDF passes C++ tests.

@bdice

bdice commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit f3574e9 into rapidsai:main Apr 29, 2026
19 checks passed
@nirandaperera

nirandaperera commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @bdice for taking care of this

rapids-bot Bot pushed a commit to rapidsai/rapidsmpf that referenced this pull request May 6, 2026
@nirandaperera
Remove memory resources from Statistics (#1003)
94e6bb8 
## Remove memory resources from `Statistics` construction

`Statistics` held `RmmResourceAdaptor` and `PinnedMemoryResource` as instance fields, tying resource lifetime to the stats object and preventing a single `Statistics` instance from being used with different resources at report time.

### Solution
- Remove `mr_` / `pinned_mr_` fields and the `Statistics(RmmResourceAdaptor, ...)` constructor; `report()` and `create_memory_recorder()` now accept explicit `std::optional<any_device_resource>` / `std::optional<any_host_device_resource>` parameters — callers supply resources at use time.
- Add `try_pinned_mr()` returning `std::optional<any_host_device_resource>` non-throwingly; correct `pinned_mr()` return type to `host_device_async_resource_ref`.
- Add `memory/resource_types.hpp` with `any_device_resource` / `any_host_device_resource` aliases; update `RAPIDSMPF_MEMORY_PROFILE` macro to require an explicit `mr` argument.

Closes #979 

Depends on rapidsai/rapids-cmake#1008 and #985

Authors:
  - Niranda Perera (https://github.com/nirandaperera)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)

URL: #1003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

Assignees

@bdice bdice

@nirandaperera nirandaperera

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nirandaperera @robertmaynard @bdice