This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Gpuciscripts clean and update - #321
Merged
Merged
Conversation
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
ajschmidt8
suggested changes
Nov 10, 2020
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
It looks like my review comments from the raft PR below will apply here as well (remove gpuci_logger function and fix export PARALLEL_LEVEL=${PARALLEL_LEVEL:-4}).
Contributor
|
Duplicate of: #314 |
Contributor
Author
gpuci_logger and parallel level changed. |
ajschmidt8
reviewed
Nov 16, 2020
Contributor
Author
|
rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CI folder the following changes have been made:
Remove logger function and replace all logger calls with gpuci_logger
Removed all ellipses ... from logger messages
Prepend /opt to the conda path in PATH variable
Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)
Replace source activate with the following:
. /opt/conda/etc/profile.d/conda.sh
conda activate rapids
Replace conda list with more verbose information:
conda info
conda config --show-sources
conda list --show-channel-urls
Update Copyright year in the top of scripts to include 2020 if applicable
Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}
Set gpuci_conda_retry flags in cpu/build.sh
Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
export GPUCI_CONDA_RETRY_MAX=1
export GPUCI_CONDA_RETRY_SLEEP=30
Replace calls to gcc and g++ with $CC and $CXX respectively