Skip to content

fix(ci): license checks Ci fix #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 7 commits into from
Jul 30, 2026
Merged

fix(ci): license checks Ci fix #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64931f7
Add CI specific yaml, also add fetch depth
johallar Jul 29, 2026
4dadbdf
does it still fail with this
johallar Jul 29, 2026
cb260bd
resource timeline should fail license check
johallar Jul 29, 2026
7c22dff
fix: fix license formatting for _all_ files
johallar Jul 29, 2026
2153ccc
test: fail resourcetimeline
johallar Jul 29, 2026
da83060
Add fetch depth back
johallar Jul 29, 2026
d5a264b
Fix resource timeline
johallar Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/license-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ jobs:
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
# Shallow clone makes the hook fall back to HEAD and check nothing.
fetch-depth: 0
persist-credentials: false
- uses: prefix-dev/setup-pixi@5185adfbffb4bd703da3010310260805d89ebb11 # v0.9.6
with:
cache: true
- name: Check SPDX license headers
run: pixi run pre-commit run verify-copyright --all-files
run: pixi run pre-commit run verify-copyright --all-files -c .pre-commit-config.ci.yaml
30 changes: 30 additions & 0 deletions .pre-commit-config.ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# CI-only config for verify-copyright: check-only (no --fix), and --force-spdx
# so --all-files actually inspects every matched file (hook otherwise only
# diffs against the target branch).

exclude: |
(?x)
^target/
^ui/node_modules/
^ui/.pnpm-store/
^docs/

Comment on lines +8 to +14

@coderabbitai coderabbitai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Separate the global exclusions with alternation operators.

Because (?x) ignores newlines and indentation, these patterns are currently concatenated into one regex. None of target/, ui/node_modules/, ui/.pnpm-store/, or docs/ is independently excluded, so matching files in those directories can still be checked.

Proposed fix 
 exclude: |
   (?x)
-    ^target/
-    ^ui/node_modules/
-    ^ui/.pnpm-store/
+    ^target/|
+    ^ui/node_modules/|
+    ^ui/.pnpm-store/|
     ^docs/
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
exclude: |
(?x)
^target/
^ui/node_modules/
^ui/.pnpm-store/
^docs/
exclude: |
(?x)
^target/|
^ui/node_modules/|
^ui/.pnpm-store/|
^docs/
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.pre-commit-config.ci.yaml around lines 8 - 14, Update the global exclude
regex after the (?x) flag so each directory pattern is separated with
alternation operators, preserving independent exclusions for target/,
ui/node_modules/, ui/.pnpm-store/, and docs/.

repos:

- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v1.5.1
hooks:
- id: verify-copyright
args: [--force-spdx]
exclude: |
(?x)
bridge/include/rust/cxx\.h$|
bridge/include/quent-bridge/gen/|
examples/simulator/server/ts-bindings/
files: |
(?x)
CMakeLists\.txt$|
[.](rs|js|ts|tsx|jsx|mjs|cjs|py|sh|cpp|h|proto|css)$
2 changes: 2 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#
# Run on all files (bulk update):
# pixi run pre-commit run verify-copyright --all-files
#
# CI uses .pre-commit-config.ci.yaml (check-only, --force-spdx).

exclude: |
(?x)
Expand Down
5 changes: 5 additions & 0 deletions domains/query_engine/tests/cpp/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# cmake-format: off
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
# cmake-format: on

cmake_minimum_required(VERSION 3.24)
project(quent-qe-cpp-example LANGUAGES CXX)

Expand Down
5 changes: 5 additions & 0 deletions domains/query_engine/tests/cpp/cpp/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/

// Query engine C++ integration test.
//
// Calls every generated CXX bridge function to catch regressions.
Expand Down
5 changes: 5 additions & 0 deletions examples/cpp-integration/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# cmake-format: off
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
# cmake-format: on

cmake_minimum_required(VERSION 3.24)
project(quent-cpp-example LANGUAGES CXX)

Expand Down
5 changes: 5 additions & 0 deletions examples/cpp-integration/cpp/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/

// Example: C++ application using quent model-generated instrumentation API.
//
// This exercises the same model as the Rust README example:
Expand Down