fix(ci): license checks Ci fix - #490
Conversation
📝 WalkthroughWalkthroughChangesLicense verification
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.pre-commit-config.ci.yaml:
- Around line 8-14: Update the global exclude regex after the (?x) flag so each
directory pattern is separated with alternation operators, preserving
independent exclusions for target/, ui/node_modules/, ui/.pnpm-store/, and
docs/.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 337bb3f5-92d4-4ab2-a384-9711383bf30d
📒 Files selected for processing (7)
.github/workflows/license-check.yml.pre-commit-config.ci.yaml.pre-commit-config.yamldomains/query_engine/tests/cpp/cpp/CMakeLists.txtdomains/query_engine/tests/cpp/cpp/src/main.cppexamples/cpp-integration/cpp/CMakeLists.txtexamples/cpp-integration/cpp/src/main.cpp
| exclude: | | ||
| (?x) | ||
| ^target/ | ||
| ^ui/node_modules/ | ||
| ^ui/.pnpm-store/ | ||
| ^docs/ | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Separate the global exclusions with alternation operators.
Because (?x) ignores newlines and indentation, these patterns are currently concatenated into one regex. None of target/, ui/node_modules/, ui/.pnpm-store/, or docs/ is independently excluded, so matching files in those directories can still be checked.
Proposed fix
exclude: |
(?x)
- ^target/
- ^ui/node_modules/
- ^ui/.pnpm-store/
+ ^target/|
+ ^ui/node_modules/|
+ ^ui/.pnpm-store/|
^docs/📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| exclude: | | |
| (?x) | |
| ^target/ | |
| ^ui/node_modules/ | |
| ^ui/.pnpm-store/ | |
| ^docs/ | |
| exclude: | | |
| (?x) | |
| ^target/| | |
| ^ui/node_modules/| | |
| ^ui/.pnpm-store/| | |
| ^docs/ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.pre-commit-config.ci.yaml around lines 8 - 14, Update the global exclude
regex after the (?x) flag so each directory pattern is separated with
alternation operators, preserving independent exclusions for target/,
ui/node_modules/, ui/.pnpm-store/, and docs/.
|
/merge |
Description
Related Issues
Testing
Screenshots