Skip to content

fix(ci): license checks Ci fix - #490

Merged
rapids-bot[bot] merged 7 commits into
rapidsai:mainfrom
johallar:license-checks-fix
Jul 30, 2026
Merged

fix(ci): license checks Ci fix#490
rapids-bot[bot] merged 7 commits into
rapidsai:mainfrom
johallar:license-checks-fix

Conversation

@johallar

Copy link
Copy Markdown
Contributor

Description

Related Issues

Testing

Screenshots

@johallar
johallar marked this pull request as ready for review July 29, 2026 20:45
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

License verification

Layer / File(s) Summary
CI verification configuration
.pre-commit-config.ci.yaml, .pre-commit-config.yaml, .github/workflows/license-check.yml
Adds check-only SPDX verification settings, selects the CI configuration, and changes checkout to fetch full history.
Source license headers
domains/query_engine/tests/cpp/cpp/*, examples/cpp-integration/cpp/*
Adds SPDX copyright and Apache-2.0 headers to the affected CMake and C++ files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • rapidsai/quent#422: Updates the same license-check workflow and pre-commit copyright verification behavior.

Suggested labels: improvement, non-breaking

Suggested reviewers: johanpel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The template is present, but Description, Related Issues, and Testing are empty placeholders, so the PR description is largely incomplete. Fill in what changed and why, link any related issues, and describe the tests you ran; include screenshots only if the change is UI-related.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and related to the CI license-check changes, though the wording is a bit awkward.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.pre-commit-config.ci.yaml:
- Around line 8-14: Update the global exclude regex after the (?x) flag so each
directory pattern is separated with alternation operators, preserving
independent exclusions for target/, ui/node_modules/, ui/.pnpm-store/, and
docs/.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 337bb3f5-92d4-4ab2-a384-9711383bf30d

📥 Commits

Reviewing files that changed from the base of the PR and between 7d622c9 and d5a264b.

📒 Files selected for processing (7)
  • .github/workflows/license-check.yml
  • .pre-commit-config.ci.yaml
  • .pre-commit-config.yaml
  • domains/query_engine/tests/cpp/cpp/CMakeLists.txt
  • domains/query_engine/tests/cpp/cpp/src/main.cpp
  • examples/cpp-integration/cpp/CMakeLists.txt
  • examples/cpp-integration/cpp/src/main.cpp

Comment on lines +8 to +14
exclude: |
(?x)
^target/
^ui/node_modules/
^ui/.pnpm-store/
^docs/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Separate the global exclusions with alternation operators.

Because (?x) ignores newlines and indentation, these patterns are currently concatenated into one regex. None of target/, ui/node_modules/, ui/.pnpm-store/, or docs/ is independently excluded, so matching files in those directories can still be checked.

Proposed fix
 exclude: |
   (?x)
-    ^target/
-    ^ui/node_modules/
-    ^ui/.pnpm-store/
+    ^target/|
+    ^ui/node_modules/|
+    ^ui/.pnpm-store/|
     ^docs/
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
exclude: |
(?x)
^target/
^ui/node_modules/
^ui/.pnpm-store/
^docs/
exclude: |
(?x)
^target/|
^ui/node_modules/|
^ui/.pnpm-store/|
^docs/
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.pre-commit-config.ci.yaml around lines 8 - 14, Update the global exclude
regex after the (?x) flag so each directory pattern is separated with
alternation operators, preserving independent exclusions for target/,
ui/node_modules/, ui/.pnpm-store/, and docs/.

@johallar

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b8eed0f into rapidsai:main Jul 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants