Skip to content

Update faiss version to match cuml#607

Merged
raydouglass merged 2 commits intobranch-23.02from
faiss-version
Feb 3, 2023
Merged

Update faiss version to match cuml#607
raydouglass merged 2 commits intobranch-23.02from
faiss-version

Conversation

@raydouglass
Copy link
Contributor

@raydouglass raydouglass self-assigned this Feb 3, 2023
@raydouglass raydouglass requested a review from a team as a code owner February 3, 2023 15:26
@raydouglass
Copy link
Contributor Author

Dante pointed out that cuml actually inherits raft's faiss version here: https://github.com/rapidsai/raft/blob/branch-23.02/conda/recipes/libraft/conda_build_config.yaml#L23

@raydouglass raydouglass merged commit f814aa6 into branch-23.02 Feb 3, 2023
@raydouglass raydouglass deleted the faiss-version branch February 3, 2023 15:49
@bdice
Copy link
Contributor

bdice commented Feb 3, 2023

We need to pin this to "1.7.2 *_cuda". The GPU selector package won't work properly with channel priority and we have to pull faiss from rapidsai. The conda-forge variants don't have ARM+CUDA at all, and won't support x86_64 on arch 90. We built packages of libfaiss for the rapidsai channel from the recipe in this PR: conda-forge/faiss-split-feedstock#64

I will open a new PR to update that pinning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants