Skip to content

Update CUDA arches for CUDA 11.8 / sm_90 support.#64

Closed
bdice wants to merge 12 commits intoconda-forge:mainfrom
bdice:update-cuda-arches
Closed

Update CUDA arches for CUDA 11.8 / sm_90 support.#64
bdice wants to merge 12 commits intoconda-forge:mainfrom
bdice:update-cuda-arches

Conversation

@bdice
Copy link

@bdice bdice commented Jan 9, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice
Copy link
Author

bdice commented Jan 9, 2023

@jakirkham Does this look like an appropriate change to the feedstock for local builds using newer CUDA versions? It also improves ARM / CUDA compatibility for CUDA 11.1+.

@bdice
Copy link
Author

bdice commented Jan 9, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/faiss-split-feedstock/actions/runs/3878346693.

@jakirkham
Copy link
Member

This will likely require similar changes as were made in PR ( conda-forge/ptxcompiler-feedstock#7 ) to build with a newer CUDA version (if that is what is desired)

@h-vetinari
Copy link
Member

This will likely require similar changes as were made in PR ( conda-forge/ptxcompiler-feedstock#7 ) to build with a newer CUDA version (if that is what is desired)

Shouldn't this come from c-f infra rather than having to manually set this in cbc.yaml?

@jakirkham
Copy link
Member

Since this PR was started, CUDA 11.8 was added to conda-forge with a migrator ( conda-forge/conda-forge-pinning-feedstock#4834 )

Here is the bot PR ( #70 )

As the logic in the recipe has changed a fair bit, found it easier to add the CUDA 11.8 change in the bot PR. Though please let me know if anything else is needed. Commented on the relevant portion of the diff to highlight this change for discussion: #70 (comment)

Also please let me know if there's anything else needed from this PR

@bdice
Copy link
Author

bdice commented Mar 27, 2024

Closing as stale.

@bdice bdice closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants