Skip to content
This repository was archived by the owner on Jul 25, 2023. It is now read-only.

FIX Update gcc7 builds to use gcc9 libstdc++.so - #159

Merged
mike-wendt merged 18 commits into
branch-0.18from
fix-gcc7-builds
Feb 11, 2021
Merged

FIX Update gcc7 builds to use gcc9 libstdc++.so#159
mike-wendt merged 18 commits into
branch-0.18from
fix-gcc7-builds

Conversation

@mike-wendt

@mike-wendt mike-wendt commented Feb 5, 2021

Copy link
Copy Markdown
Contributor
  • Update centos gcc7 build to include gcc9 libstdc++.so
  • Update ubuntu18.04 devel builds for rapidsai to include and upgrade for libstdc++6 pkg to upgrade to 10.1 - Done in Install libstdc++6 #160

After #153 building with system gcc7 compilers and the conda gcc9 runtime libraries causes an ABI mismatch and prevents from-source builds in the rapidsai/rapidsai-core-dev containers. Updating the gcc7 tarball for centos 7/8 and upgrading libstdc++6 pkg on ubuntu18.04 will solve this issue for those systems.

ubuntu16.04, ubuntu20.04 are not impacted as 16.04 has version 9.3 already and 20.04 has version 10.2

We will need to create a RAPIDS Notice for developers to update them on this change for from-source builds with conda dependencies

@mike-wendt

mike-wendt commented Feb 5, 2021

Copy link
Copy Markdown
Contributor Author

PR using in repo-branch for testing with existing scripts that use this repo as a base; will post results when done

@mike-wendt

Copy link
Copy Markdown
Contributor Author

Built new gcc7 tarball with gcc9 libstdc++ - https://gpuci.gpuopenanalytics.com/job/gpuci/job/docker/job/builds/job/gcc7-docker/10/

@mike-wendt

Copy link
Copy Markdown
Contributor Author

@mike-wendt

Copy link
Copy Markdown
Contributor Author

Will run test builds now and check resulting centos and ubuntu18.04 images for patches

@mike-wendt

Copy link
Copy Markdown
Contributor Author

With the tarball live in S3 #156 is building currently and will use the new gcc7 patched tarball. I'll test those images when they finish to verify the patch works for this part

The ubuntu18.04 images will need separate testing and I'll launch those once #156 is verified and merged so I can use the updated and fixed scripts with the PR merge test - this way I won't run into a bunch of failed jobs blocking the testing

@mike-wendt

mike-wendt commented Feb 5, 2021

Copy link
Copy Markdown
Contributor Author

Verified gcc7 patched tarball has correct libstdc++ lib in this image gpucitesting/rapidsai-pr156:0.19-cuda10.1-devel-centos7-py3.7

Once #156 is merged I'll test ubuntu18.04

@mike-wendt
mike-wendt marked this pull request as ready for review February 5, 2021 06:38
@mike-wendt
mike-wendt requested a review from a team as a code owner February 5, 2021 06:38
@mike-wendt mike-wendt changed the title FIX Update gcc7 builds to use gcc9 libstdc++.so [skip-ci] FIX Update gcc7 builds to use gcc9 libstdc++.so Feb 5, 2021
@mike-wendt

Copy link
Copy Markdown
Contributor Author

rerun tests

@mike-wendt

mike-wendt commented Feb 8, 2021

Copy link
Copy Markdown
Contributor Author

FWIW here is the gcc7 tarball from June that we were using

Extract into /usr/local/gcc7 in use

@raydouglass raydouglass mentioned this pull request Feb 8, 2021
1 task
This is to prevent updates that can cause glibc bugs during compile time
The patched version of glibc today, fixes the glibc issues we've seen
@mike-wendt

Copy link
Copy Markdown
Contributor Author

rerun tests

@mike-wendt

Copy link
Copy Markdown
Contributor Author

From testing in rapidsai/docker#259 this is good to merge

@mike-wendt
mike-wendt merged commit 4f1d1f6 into branch-0.18 Feb 11, 2021
@mike-wendt
mike-wendt deleted the fix-gcc7-builds branch February 11, 2021 05:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants