Skip to content

add fallbacks in checks with '-z' #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 3 commits into from
May 14, 2025
Merged

add fallbacks in checks with '-z' #179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb5258e
add fallbacks in checks with '-z'
jameslamb May 13, 2025
f6eae7b
Update tools/rapids-upload-to-s3
jameslamb May 14, 2025
39fa7cd
Merge branch 'main' into fix/arg-processing
jameslamb May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/rapids-download-from-s3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
set -euo pipefail
export RAPIDS_SCRIPT_NAME="rapids-download-from-s3"

if [ -z "$1" ] || [ -z "$2" ]; then
if [ -z "${1:-}" ] || [ -z "${2:-}" ]; then
rapids-echo-stderr "Must specify input arguments: PKG_NAME and UNTAR_DEST"
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion tools/rapids-extract-conda-files
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -eo pipefail
export RAPIDS_SCRIPT_NAME="rapids-extract-conda-files"

if [ -z "$1" ]; then
if [ -z "${1:-}" ]; then
rapids-echo-stderr "Must specify input argument: CONDA_PKG_DIR"
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion tools/rapids-package-name
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export RAPIDS_SCRIPT_NAME="rapids-package-name"

repo_name="${RAPIDS_REPOSITORY##*/}"

if [ -z "$1" ]; then
if [ -z "${1:-}" ]; then
rapids-echo-stderr "Must specify input arguments: PKG_TYPE"
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion tools/rapids-pip-wheel-version
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
set -exo pipefail
export RAPIDS_SCRIPT_NAME="rapids-pip-wheel-version"

if [ -z "$1" ]; then
if [ -z "${1:-}" ]; then
rapids-echo-stderr "Must specify input arguments: EPOCH_TIMESTAMP"
exit 1
fi
Expand Down
4 changes: 2 additions & 2 deletions tools/rapids-upload-to-s3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
# 1) package name
# 2) path to tar up
set -eo pipefail
source rapids-constants
#source rapids-constants
Comment thread
jameslamb marked this conversation as resolved.
Outdated
export RAPIDS_SCRIPT_NAME="rapids-upload-to-s3"

if [ -z "$1" ] || [ -z "$2" ]; then
if [ -z "${1:-}" ] || [ -z "${2:-}" ]; then
rapids-echo-stderr "Must specify both input arguments: PACKAGE_NAME and PATH_TO_TAR_UP"
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion tools/rapids-wheel-ctk-name-gen
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# 1) ctk tag
set -eu -o pipefail

if [ -z "${1-}" ]; then
if [ -z "${1:-}" ]; then
rapids-echo-stderr "Must specify input argument: CTK_TAG"
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion tools/rapids-wheels-anaconda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ set -eou pipefail
source rapids-constants
export RAPIDS_SCRIPT_NAME="rapids-wheels-anaconda"

if [ -z "$1" ]; then
if [ -z "${1:-}" ]; then
rapids-echo-stderr "Must specify input arguments: WHEEL_NAME"
exit 1
fi
Expand Down
4 changes: 2 additions & 2 deletions tools/rapids-wheels-anaconda-github
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
set -eou pipefail
export RAPIDS_SCRIPT_NAME="rapids-wheels-anaconda-github"

if [ -z "$1" ]; then
rapids-echo-stderr "Must specify input arguments: WHEEL_NAME"
if [ -z "${1:-}" ] || [ -z "${2:-}" ]; then
rapids-echo-stderr "Must specify input arguments: WHEEL_NAME and PKG_TYPE"
exit 1
fi
WHEEL_NAME="$1"
Expand Down