add fallbacks in checks with '-z' - #179
Merged
Merged
Conversation
gforsyth
reviewed
May 14, 2025
gforsyth
left a comment
Contributor
There was a problem hiding this comment.
Big fan of this -- just one question on a stray commented out line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been spending a lot of time in this repo recently and have seen a recurring pattern.
Checks like this:
If code like that is run when
set -uis set, that informative error message and other code inside thethenblock will never be executed... bash will exit immediately with an error like "unbound variable ...".This adds a fallback to null in all such checks I could find, to avoid that.
Notes for Reviewers
How I found these
Recent Examples