Skip to content

Disable install Dask master in CI - #645

Merged
ajschmidt8 merged 4 commits into
rapidsai:branch-21.06from
pentschev:disable-install-dask-master
Jun 7, 2021
Merged

ajschmidt8 merged 4 commits into
rapidsai:branch-21.06from
pentschev:disable-install-dask-master

Conversation

@pentschev

Copy link
Copy Markdown
Member

No description provided.

@pentschev
pentschev requested a review from a team as a code owner June 7, 2021 18:35
@github-actions github-actions Bot added the gpuCI gpuCI issue label Jun 7, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jun 7, 2021
@ajschmidt8

Copy link
Copy Markdown
Member

This will require a manual merge once CI is complete.

@github-actions github-actions Bot added the conda conda issue label Jun 7, 2021
@ajschmidt8

Copy link
Copy Markdown
Member

@pentschev, can you elaborate on the numba change in 9d76971?

@pentschev

Copy link
Copy Markdown
Member Author

I thought the build failure was about the Numba version, because the rest of RAPIDS now pins Numba>=0.53.1:

20:40:36 /tmp/tmp26qug3g1/dask-cuda-21.06.00a-py37_56.tar.bz2: C1114 Found invalid dependency "numba >=0.50.0,!=0.51.0" in info/index.json

With the above said, I'm not 100% certain this is the (only) issue.

@pentschev

Copy link
Copy Markdown
Member Author

The Numba error is now gone (or not even reached), but there's this one now:

20:52:46 TESTS FAILED: dask-cuda-21.06.00a-py37_57.tar.bz2
20:52:49     [gpuci_conda_retry] conda returned exit code: 1
20:52:49     [gpuci_conda_retry] Exiting, no retryable conda errors detected: 'ChecksumMismatchError:' or 'CondaHTTPError:' or 'JSONDecodeError:' or 'ChunkedEncodingError:' or 'CondaMultiError:'
20:52:49     [gpuci_conda_retry] 
20:52:49 Build step 'Execute shell' marked build as failure
20:52:53 [Set GitHub commit status (universal)] ERROR on repos [GHRepository@30668f7b[nodeId=MDEwOlJlcG9zaXRvcnkxNjU5MjY5Nzc=,description=Utilities for Dask and CUDA interactions,homepage=,name=dask-cuda,fork=false,archived=false,size=1100,milestones={},language=Python,commits={},source=<null>,parent=<null>,isTemplate=<null>,url=https://api.github.com/repos/rapidsai/dask-cuda,id=165926977,nodeId=<null>,createdAt=2019-01-15T21:33:16Z,updatedAt=2021-06-07T16:04:05Z]] (sha:9d76971) with context:gpuCI/dask-cuda/build/python/3.7
20:52:53 Setting commit status on GitHub for https://github.com/rapidsai/dask-cuda/commit/9d7697182f2dd4a74da8f8d2d051d44b7a1eacb1
20:52:53 Finished: FAILURE

This looks like a CI issue, could you check @ajschmidt8 ?

@ajschmidt8

Copy link
Copy Markdown
Member

@pentschev, I'm seeing this error message hidden in the log text. Can you take a look?

image

@jakirkham

Copy link
Copy Markdown
Member

@galipremsagar would you be able to look at the issue AJ shared above? 🙂

@pentschev

Copy link
Copy Markdown
Member Author

I'm seeing this error message hidden in the log text. Can you take a look?

Wait a second, I'm confused now. What's this build doing exactly? This error is because we're picking Dask 2021.06.0, which is exactly what I'm trying to prevent with this PR. AFAIK, 21.06 should pin to Dask 2021.05.1.

@pentschev

Copy link
Copy Markdown
Member Author

@jakirkham I think Prem is good, the problem is that we're picking Dask 2021.06.0, which is not what RAPIDS should be pinning to.

@jakirkham jakirkham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is related to getting the newer dask + distributed versions, we likely need to constrain them

Comment thread conda/recipes/dask-cuda/meta.yaml Outdated
Comment thread requirements.txt Outdated
@ajschmidt8

ajschmidt8 commented Jun 7, 2021

Copy link
Copy Markdown
Member

If this is related to getting the newer dask + distributed versions, we likely need to constrain them

That sounds like it could be the problem. @pentschev, thoughts? Can you try updating your PR to include this?

EDIT---
whoops, I missed the above conversation by not refreshing my page. I see the latest commit now.

@codecov-commenter

codecov-commenter commented Jun 7, 2021

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@0d6c3b7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a610297 differs from pull request most recent head 745b3a9. Consider uploading reports for the commit 745b3a9 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06     #645   +/-   ##
===============================================
  Coverage                ?   90.56%           
===============================================
  Files                   ?       15           
  Lines                   ?     1622           
  Branches                ?        0           
===============================================
  Hits                    ?     1469           
  Misses                  ?      153           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6c3b7...745b3a9. Read the comment docs.

@pentschev

Copy link
Copy Markdown
Member Author

For some reason, the test that failed is supposed to be skipped in CUDA < 11.2 but it ran anyway on the 11.0 build. I'm rerunning the tests and trying to reproduce locally in the meantime.

@pentschev

Copy link
Copy Markdown
Member Author

rerun tests

@jakirkham

Copy link
Copy Markdown
Member

It's encouraging to see the other failures went away though :)

@pentschev
pentschev requested a review from a team as a code owner June 7, 2021 20:31
@github-actions github-actions Bot added the python python code needed label Jun 7, 2021
@pentschev

Copy link
Copy Markdown
Member Author

The condition was wrong, I think the latest commit will fix the issue.

@pentschev

Copy link
Copy Markdown
Member Author

Everything passes now! @ajschmidt8 could you merge this?

@ajschmidt8

Copy link
Copy Markdown
Member

CI is passing. Versions match the integration repo. merging to 21.06.

@ajschmidt8
ajschmidt8 merged commit 0e382e4 into rapidsai:branch-21.06 Jun 7, 2021
@pentschev
pentschev deleted the disable-install-dask-master branch June 29, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team bug Something isn't working conda conda issue gpuCI gpuCI issue non-breaking Non-breaking change python python code needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants