Skip to content

Update UCX-Py version to 0.21 - #1650

Merged
rapids-bot[bot] merged 3 commits into
rapidsai:branch-21.08from
pentschev:update-ucx-py-version-0.21
Jun 14, 2021
Merged

rapids-bot[bot] merged 3 commits into
rapidsai:branch-21.08from
pentschev:update-ucx-py-version-0.21

Conversation

@pentschev

Copy link
Copy Markdown
Member

No description provided.

@pentschev

Copy link
Copy Markdown
Member Author

Waiting for #1649 to be merged first.

@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Jun 7, 2021

@rlratzel rlratzel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread ci/release/update-version.sh Outdated
sed_runner "s/dask-cuda=${CURRENT_SHORT_TAG}/dask-cuda=${NEXT_SHORT_TAG}/g" ${FILE};
sed_runner "s/dask-cudf=${CURRENT_SHORT_TAG}/dask-cudf=${NEXT_SHORT_TAG}/g" ${FILE};
sed_runner "s/ucx-py=${CURRENT_SHORT_TAG}/ucx-py=${NEXT_SHORT_TAG}/g" ${FILE};
sed_runner "s/ucx-py=0.21/ucx-py=0.21/g" ${FILE};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a no-op, so we can remove this line.

@ajschmidt8
ajschmidt8 marked this pull request as ready for review June 7, 2021 15:44
@ajschmidt8
ajschmidt8 requested a review from a team as a code owner June 7, 2021 15:44
@codecov-commenter

codecov-commenter commented Jun 7, 2021

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@6b5079c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1650   +/-   ##
===============================================
  Coverage                ?   59.68%           
===============================================
  Files                   ?       80           
  Lines                   ?     3542           
  Branches                ?        0           
===============================================
  Hits                    ?     2114           
  Misses                  ?     1428           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5079c...62632c8. Read the comment docs.

@ajschmidt8

Copy link
Copy Markdown
Member

@gpucibot merge

@pentschev

Copy link
Copy Markdown
Member Author

Seems like there are several potentially legit cuGraph failures here, @rlratzel @BradReesWork could you take a look?

@pentschev

Copy link
Copy Markdown
Member Author

Oh, actually those seem to be because we're installing Dask/Distributed 2021.5.1, but we need 2021.6.0 or main for branch-21.08. It seems that this was covered by

cugraph/ci/gpu/build.sh

Lines 75 to 77 in 6aab21f

gpuci_logger "Install the master version of dask and distributed"
pip install "git+https://github.com/dask/distributed.git" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git" --upgrade --no-deps
but something is downgrading them after that, perhaps we need rapidsai/dask-cuda#645 first.

@pentschev

Copy link
Copy Markdown
Member Author

Actually no, rapidsai/dask-cuda#645 won't help because it targets branch-21.06. I think something in the following block is downgrading Dask/Distributed:

cugraph/ci/gpu/build.sh

Lines 89 to 113 in 6aab21f

################################################################################
# BUILD - Build libcugraph and cuGraph from source
################################################################################
if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then
gpuci_logger "Build from source"
$WORKSPACE/build.sh -v clean libcugraph cugraph
else
export LIBCUGRAPH_BUILD_DIR="$WORKSPACE/ci/artifacts/cugraph/cpu/conda_work/cpp/build"
# Faiss patch
echo "Update libcugraph.so"
cd $LIBCUGRAPH_BUILD_DIR
chrpath -d libcugraph.so
patchelf --replace-needed `patchelf --print-needed libcugraph.so | grep faiss` libfaiss.so libcugraph.so
CONDA_FILE=`find ${CONDA_ARTIFACT_PATH} -name "libcugraph*.tar.bz2"`
CONDA_FILE=`basename "$CONDA_FILE" .tar.bz2` #get filename without extension
CONDA_FILE=${CONDA_FILE//-/=} #convert to conda install
echo "Installing $CONDA_FILE"
conda install -c ${CONDA_ARTIFACT_PATH} "$CONDA_FILE"
echo "Build cugraph..."
$WORKSPACE/build.sh cugraph
fi

I'm not sure what package is the cause for downgrade, but perhaps we could move the Dask install after cuGraph? Also, this will need to wait for rapidsai/dask-cuda#647, as rapidsai/dask-cuda#645 just got merged and that pins 2021.5.1 in Dask-CUDA.

@pentschev

Copy link
Copy Markdown
Member Author

rerun tests

@pentschev

Copy link
Copy Markdown
Member Author

Rerunning tests now that cuDF and integration repo have been updated.

@ajschmidt8

Copy link
Copy Markdown
Member

looks like this might be blocked by #1637 now. that one should hopefully be merged soon.

@ajschmidt8

Copy link
Copy Markdown
Member

@pentschev, can you pull the latest changes here now that #1637 is merged?

@pentschev

Copy link
Copy Markdown
Member Author

can you pull the latest changes here now that #1637 is merged?

Done.

@rapids-bot
rapids-bot Bot merged commit 93c6e03 into rapidsai:branch-21.08 Jun 14, 2021
@pentschev
pentschev deleted the update-ucx-py-version-0.21 branch June 28, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants