-
Notifications
You must be signed in to change notification settings - Fork 109
Build and test with CUDA 13.0.0 #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2fbe13a
Build and test with CUDA 13.0.0
jameslamb 25d028c
update dependencies.yaml
jameslamb 1824e35
empty commit to fully re-build and re-test with moved numba-cuda pins
jameslamb 37e3086
merge main
jameslamb caf5b43
merge main
jameslamb 08d5a84
introduce [cu12] and [cu13] extras
jameslamb 041fab0
try to make 'cudf' and 'dask_cudf' optional for tests
jameslamb 4a7e4db
add cudf back to Python 3.12 environment
jameslamb c457f1f
add dask[dataframe] to wheel testing dependencies
jameslamb 97f2bfb
restore cudf and dask-cudf on CUDA 12, update comment, fix == for kvikio
jameslamb 087d1fe
remove numactl
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # This file is generated by `rapids-dependency-file-generator`. | ||
| # To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`. | ||
| channels: | ||
| - rapidsai | ||
| - rapidsai-nightly | ||
| - conda-forge | ||
| dependencies: | ||
| - click >=8.1 | ||
| - cuda-nvcc-impl | ||
| - cuda-nvrtc | ||
| - cuda-version=13.0 | ||
| - cudf==25.10.*,>=0.0.0a0 | ||
| - dask-cudf==25.10.*,>=0.0.0a0 | ||
| - distributed-ucxx==0.46.*,>=0.0.0a0 | ||
| - kvikio==25.10.*,>=0.0.0a0 | ||
| - numactl-devel-cos7-aarch64 | ||
| - numba-cuda>=0.19.0,<0.20.0a0 | ||
| - numba>=0.60.0,<0.62.0a0 | ||
| - numpy>=1.23,<3.0a0 | ||
| - numpydoc>=1.1.0 | ||
| - pandas>=1.3 | ||
| - pre-commit | ||
| - pynvml>=12.0.0,<13.0.0a0 | ||
| - pytest | ||
| - pytest-cov | ||
| - pytest-timeout | ||
| - python>=3.10,<3.14 | ||
| - rapids-build-backend>=0.4.0,<0.5.0dev0 | ||
| - rapids-dask-dependency==25.10.*,>=0.0.0a0 | ||
| - setuptools>=64.0.0 | ||
| - sphinx | ||
| - sphinx-click>=2.7.1 | ||
| - sphinx-rtd-theme>=0.5.1 | ||
| - ucx-py==0.46.*,>=0.0.0a0 | ||
| - ucxx==0.46.*,>=0.0.0a0 | ||
| - zict>=2.0.0 | ||
| name: all_cuda-130_arch-aarch64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # This file is generated by `rapids-dependency-file-generator`. | ||
| # To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`. | ||
| channels: | ||
| - rapidsai | ||
| - rapidsai-nightly | ||
| - conda-forge | ||
| dependencies: | ||
| - click >=8.1 | ||
| - cuda-nvcc-impl | ||
| - cuda-nvrtc | ||
| - cuda-version=13.0 | ||
| - cudf==25.10.*,>=0.0.0a0 | ||
| - dask-cudf==25.10.*,>=0.0.0a0 | ||
| - distributed-ucxx==0.46.*,>=0.0.0a0 | ||
| - kvikio==25.10.*,>=0.0.0a0 | ||
| - numactl-devel-cos7-x86_64 | ||
| - numba-cuda>=0.19.0,<0.20.0a0 | ||
| - numba>=0.60.0,<0.62.0a0 | ||
| - numpy>=1.23,<3.0a0 | ||
| - numpydoc>=1.1.0 | ||
| - pandas>=1.3 | ||
| - pre-commit | ||
| - pynvml>=12.0.0,<13.0.0a0 | ||
| - pytest | ||
| - pytest-cov | ||
| - pytest-timeout | ||
| - python>=3.10,<3.14 | ||
| - rapids-build-backend>=0.4.0,<0.5.0dev0 | ||
| - rapids-dask-dependency==25.10.*,>=0.0.0a0 | ||
| - setuptools>=64.0.0 | ||
| - sphinx | ||
| - sphinx-click>=2.7.1 | ||
| - sphinx-rtd-theme>=0.5.1 | ||
| - ucx-py==0.46.*,>=0.0.0a0 | ||
| - ucxx==0.46.*,>=0.0.0a0 | ||
| - zict>=2.0.0 | ||
| name: all_cuda-130_arch-x86_64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blegh, ok we have to do something here.
CUDA 12.9 wheel tests are failing like this:
(build link)
The fallback matrix is used because of this:
dask-cuda/pyproject.toml
Line 127 in 0c83e51
We distribute unsuffixed packages here (
dask-cuda, notdask-cuda-cu{12,13}). Which has been fine, because this project's code isn't directly CUDA-major-version dependent and neither was its list of dependencies.... until #1531That PR introduced a CUDA-major-version-specific dependency like
numba-cuda[cu12]. When I reviewed that, I forgotdask-cudaisn't suffixed 😭This is a problem because now we want to depend on
numba-cuda[cu12]when targeting CUDA 12 andnumba-cuda[cu13]when targeting CUDA 13.The options I see are:
numba-cudawithout extrasdask-cuda-cu{12,13}It looks like those extras are probably necessary for correctness:
https://github.com/NVIDIA/numba-cuda/blob/d2827b7701289932ba390cdbf90642dcc7b2eeab/pyproject.toml#L26-L44
But I'm not sure. What do you think @bdice @brandon-b-miller @pentschev @TomAugspurger ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked offline and @bdice mentioned it might be possible to factor the
numba.cudausage here out / down in a way that allows us to continue publishing unsuffixeddask-cudawheels.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying with this change: #1537
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #1537, in more offline discussion we agreed to try adding
[cu12]and[cu13]extras for wheels, to ensure that users can get an environment with a compatible set of packages based on CUDA version.