Skip to content
This repository was archived by the owner on Jul 7, 2026. It is now read-only.

Fix/follow up to #303 - #304

Merged
rapids-bot[bot] merged 5 commits into
rapidsai:branch-21.08from
AjayThorve:fix/follow-up-to-#303
Jul 20, 2021
Merged

Fix/follow up to #303#304
rapids-bot[bot] merged 5 commits into
rapidsai:branch-21.08from
AjayThorve:fix/follow-up-to-#303

Conversation

@AjayThorve

Copy link
Copy Markdown
Member

Follow up PR to #303, fixes theme related bugs, which were introduced in the previous PR, while updating panel and bokeh version support.

This PR also fixes(handles), a weird issue where the bokeh x-axis data in CDS is converted from datetime to float during runtime, which caused a bunch of issues in the computing queries.

Will have to investigate further and try and fix this issue in the base libraries instead of cuxfilter though, more work to follow regarding that.

@AjayThorve
AjayThorve requested a review from a team as a code owner July 10, 2021 03:12
@AjayThorve AjayThorve self-assigned this Jul 10, 2021
@AjayThorve AjayThorve added non-breaking Non-breaking change bug Something isn't working labels Jul 10, 2021
@AjayThorve
AjayThorve requested a review from bryevdv July 10, 2021 03:13
@ajschmidt8

Copy link
Copy Markdown
Member

rerun tests

@bryevdv

bryevdv commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

This PR also fixes(handles), a weird issue where the bokeh x-axis data in CDS is converted from datetime to float during runtime, which caused a bunch of issues in the computing queries

Definitely would like to understand whatever is going on with this. I have not seen any other reports about types mutating and I can't find any 2.3+ PRs that seem relevant either

@AjayThorve

Copy link
Copy Markdown
Member Author

This PR also fixes(handles), a weird issue where the bokeh x-axis data in CDS is converted from datetime to float during runtime, which caused a bunch of issues in the computing queries

Definitely would like to understand whatever is going on with this. I have not seen any other reports about types mutating and I can't find any 2.3+ PRs that seem relevant either

So its more of a panel issue, whenever we start a dashboard with panel, the bokeh charts with datetime axis gets converted to float.

bokeh.io.show works fine, and does not have that issue

@AjayThorve

Copy link
Copy Markdown
Member Author

rerun tests

1 similar comment
@AjayThorve

Copy link
Copy Markdown
Member Author

rerun tests

@AjayThorve

Copy link
Copy Markdown
Member Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 9d8499d into rapidsai:branch-21.08 Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working non-breaking Non-breaking change Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants