This repository was archived by the owner on Jul 7, 2026. It is now read-only.
Fix/update bokeh version - #303
Merged
rapids-bot[bot] merged 9 commits intoJul 6, 2021
Merged
Conversation
AjayThorve
added
improvement
ajschmidt8
reviewed
Jul 1, 2021
ajschmidt8
left a comment
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
@AjayThorve, can you also open a PR to update the version below?
bryevdv
approved these changes
Jul 1, 2021
Contributor
|
LGTM I guess there is a solve issue? But it looks unrelated at a glance |
Member
Author
here you go - rapidsai/integration#308 |
ajschmidt8
approved these changes
Jul 1, 2021
ajschmidt8
reviewed
Jul 6, 2021
ajschmidt8
reviewed
Jul 6, 2021
Member
Author
|
rerun tests |
Member
Author
|
@gpucibot merge |
Merged
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
Follow up PR to #303, fixes theme related bugs, which were introduced in the previous PR, while updating panel and bokeh version support. This PR also fixes(handles), a weird issue where the bokeh x-axis data in CDS is converted from datetime to float during runtime, which caused a bunch of issues in the computing queries. Will have to investigate further and try and fix this issue in the base libraries instead of cuxfilter though, more work to follow regarding that. Authors: - Ajay Thorve (https://github.com/AjayThorve) Approvers: - Bryan Van de Ven (https://github.com/bryevdv) URL: #304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254.
Follow up PR will remove support for custom datashader extension and support the much more exhaustive version that holoviews implements