Skip to content

Updates needed when building with CUDA 13 #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Aug 7, 2025
Merged

Updates needed when building with CUDA 13 #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcb9376
Updates needed when building with CUDA 13
robertmaynard Aug 5, 2025
ec6a88f
Merge branch 'branch-25.10' into fea/add_support_for_cuda_13
cjnolet Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/cuvs/neighbors/common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ namespace filtering {
enum class FilterType { None, Bitmap, Bitset };

struct base_filter {
virtual ~base_filter() = default;
~base_filter() = default;
Copy link
Contributor

@mythrocks mythrocks Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely a silly question, but wouldn't this cause leaks or incorrect behaviour, if base_filter instances are deleted?

Copy link
Contributor Author

@robertmaynard robertmaynard Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any derived types that had local storage. If we have any derived types that do have storage they would still be okay as long as they are deleted as the derived type. ( So no holding a vector of base_filter pointers and calling delete on that ).

Copy link
Contributor

@mythrocks mythrocks Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I couldn't find that sort of thing either.

Thank you.

virtual FilterType get_filter_type() const = 0;
};

Expand Down
2 changes: 1 addition & 1 deletion cpp/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ if(BUILD_TESTS)

ConfigureTest(
NAME NEIGHBORS_ALL_NEIGHBORS_TEST PATH neighbors/all_neighbors/test_float.cu GPUS 1 PERCENT 100
ADDITIONAL_DEP nccl
ADDITIONAL_DEP NCCL::NCCL
)

ConfigureTest(
Expand Down