Updates needed when building with CUDA 13#1219
Merged
rapids-bot[bot] merged 2 commits intobranch-25.10from Aug 7, 2025
Merged
Conversation
robertmaynard
added
feature request
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
6 tasks
cjnolet
approved these changes
Aug 7, 2025
Contributor
Author
|
/merge |
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
mythrocks
reviewed
Aug 7, 2025
|
|
||
| struct base_filter { | ||
| virtual ~base_filter() = default; | ||
| ~base_filter() = default; |
Contributor
There was a problem hiding this comment.
Likely a silly question, but wouldn't this cause leaks or incorrect behaviour, if base_filter instances are deleted?
Contributor
Author
There was a problem hiding this comment.
I didn't see any derived types that had local storage. If we have any derived types that do have storage they would still be okay as long as they are deleted as the derived type. ( So no holding a vector of base_filter pointers and calling delete on that ).
Contributor
There was a problem hiding this comment.
Agreed. I couldn't find that sort of thing either.
Thank you.
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Aug 11, 2025
cuvs also requires rapidsai/raft#2774 to be merged Authors: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuvs also requires rapidsai/raft#2774 to be merged