Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Remove IncludeCategories from .clang-format#470

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.02from
codereport:cf-header
Dec 14, 2021
Merged

Remove IncludeCategories from .clang-format#470
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.02from
codereport:cf-header

Conversation

@codereport
Copy link
Contributor

@codereport codereport commented Dec 9, 2021

It was recently noticed that the IncludeCategories:

IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3

In the .clang-format are not really necessary as ext has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:

@codereport codereport requested a review from a team as a code owner December 9, 2021 17:41
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Dec 9, 2021
@codereport codereport mentioned this pull request Dec 9, 2021
Merged
@harrism harrism added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 14, 2021
harrism
harrism suggested changes Dec 14, 2021
View reviewed changes
@codereport @harrism
Update cpp/src/io/shp/polygon_shapefile_reader.cpp
f5752c6 
Co-authored-by: Mark Harris <mharris@nvidia.com>
@codereport codereport requested a review from harrism December 14, 2021 06:51
@codereport
Copy link
Contributor Author

codereport commented Dec 14, 2021

@gpucibot merge

1 similar comment
@harrism
Copy link
Member

harrism commented Dec 14, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f0cede3 into rapidsai:branch-22.02 Dec 14, 2021
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Dec 16, 2021
@codereport
Remove IncludeCategories from .clang-format (#412)
d2e5b7a 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987
* `cuspatial`: rapidsai/cuspatial#470

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #412
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

1 more reviewer

@harrism harrism harrism approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codereport @harrism