Skip to content

Remove IncludeCategories from .clang-format#4438

Merged
rapids-bot[bot] merged 11 commits intorapidsai:branch-22.02from
codereport:cf-header
Jan 8, 2022
Merged

Remove IncludeCategories from .clang-format#4438
rapids-bot[bot] merged 11 commits intorapidsai:branch-22.02from
codereport:cf-header

Conversation

@codereport
Copy link
Contributor

@codereport codereport commented Dec 9, 2021

It was recently noticed that the IncludeCategories:

IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3

In the .clang-format are not really necessary as ext has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:

@codereport codereport requested a review from a team as a code owner December 9, 2021 17:31
@wphicks wphicks added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 9, 2021
This was referenced Dec 9, 2021
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Dec 14, 2021
@codereport
Remove IncludeCategories from .clang-format (#470)
f0cede3 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #470
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Dec 16, 2021
@codereport
Remove IncludeCategories from .clang-format (#412)
d2e5b7a 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987
* `cuspatial`: rapidsai/cuspatial#470

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #412
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Dec 17, 2021
@codereport
Remove IncludeCategories from .clang-format (#1987)
2a09714 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1987
@dantegd
Copy link
Member

dantegd commented Jan 6, 2022

@codereport CI failures me are unrelated to this PR, we're triaging them currently

@codereport
Copy link
Contributor Author

codereport commented Jan 6, 2022

@codereport CI failures me are unrelated to this PR, we're triaging them currently

Awesome! I will fold the changes in once they are ready.

@codereport
Copy link
Contributor Author

codereport commented Jan 8, 2022

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@03132e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4438   +/-   ##
===============================================
  Coverage                ?   85.75%           
===============================================
  Files                   ?      236           
  Lines                   ?    19310           
  Branches                ?        0           
===============================================
  Hits                    ?    16560           
  Misses                  ?     2750           
  Partials                ?        0
Flag Coverage Δ
dask 46.54% <0.00%> (?)
non-dask 78.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03132e8...7b73f13. Read the comment docs.

divyegala
divyegala approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divyegala
Copy link
Member

divyegala commented Jan 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 416ce61 into rapidsai:branch-22.02 Jan 8, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@codereport
Remove IncludeCategories from .clang-format (rapidsai#4438)
8c30dfe 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#4438
loulankxh pushed a commit to loulankxh/raft that referenced this pull request Oct 14, 2025
@codereport
Remove IncludeCategories from .clang-format (rapidsai#412)
979379c 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987
* `cuspatial`: rapidsai/cuspatial#470

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyegala divyegala divyegala approved these changes

+1 more reviewer

@wphicks wphicks wphicks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codereport @dantegd @codecov-commenter @divyegala @wphicks