Skip to content

[FIX] Use library_dirs for cython linking, link cudatoolkit libs, allow setting UCX install location - #1698

Merged
rapids-bot[bot] merged 8 commits into
rapidsai:branch-21.08from
trxcllnt:fix/setup-py-library-dirs
Jul 9, 2021
Merged

rapids-bot[bot] merged 8 commits into
rapidsai:branch-21.08from
trxcllnt:fix/setup-py-library-dirs

Conversation

@trxcllnt

@trxcllnt trxcllnt commented Jul 7, 2021

Copy link
Copy Markdown
Collaborator

This PR is a continuation of #1694. Similar to NVIDIA/cuml#4015, this PR updates setup.py to:

  • Use library_dirs instead of runtime_library_dirs when linking Cython.
  • Allow overriding UCX lib and include dirs via a UCX_HOME envvar.
  • Link cudart, cusparse, and cusolver.

These are necessary to compile the Cython via pip when not inside a conda environment and when UCX is installed to a location other than /usr or /usr/local.

@trxcllnt
trxcllnt requested review from a team as code owners July 7, 2021 13:31
@ajschmidt8 ajschmidt8 added bug Something isn't working non-breaking Non-breaking change labels Jul 7, 2021
@codecov-commenter

codecov-commenter commented Jul 7, 2021

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@e2ac467). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1698   +/-   ##
===============================================
  Coverage                ?   59.34%           
===============================================
  Files                   ?       80           
  Lines                   ?     3559           
  Branches                ?        0           
===============================================
  Hits                    ?     2112           
  Misses                  ?     1447           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ac467...39fe4be. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.08 milestone Jul 7, 2021
@BradReesWork

Copy link
Copy Markdown
Member

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants