Update setup.py - #4015
Merged
Merged
Update setup.py#4015
Conversation
dantegd
approved these changes
Jun 29, 2021
dantegd
added
the
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4015 +/- ##
===============================================
Coverage ? 85.46%
===============================================
Files ? 230
Lines ? 18116
Branches ? 0
===============================================
Hits ? 15482
Misses ? 2634
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Contributor
|
@gpucibot merge |
rapids-bot Bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jul 9, 2021
…etting UCX install location (#1698) This PR is a continuation of #1694. Similar to NVIDIA/cuml#4015, this PR updates setup.py to: * Use `library_dirs` instead of `runtime_library_dirs` when linking Cython. * Allow overriding UCX lib and include dirs via a `UCX_HOME` envvar. * Link `cudart`, `cusparse`, and `cusolver`. These are necessary to compile the Cython via `pip` when not inside a conda environment and when UCX is installed to a location other than `/usr` or `/usr/local`. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #1698
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This PR includes some changes that were necessary to build `cuml` via CMake. Namely it includes the following changes: - Updates the `libs` list to include some additionally libraries to link against - Moves the `runtime_library_dirs` to `library_dirs` cc: @trxcllnt, who helped me get `cuml` built via CMake Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: NVIDIA#4015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some changes that were necessary to build
cumlvia CMake. Namely it includes the following changes:libslist to include some additionally libraries to link againstruntime_library_dirstolibrary_dirscc: @trxcllnt, who helped me get
cumlbuilt via CMake