Skip to content

libwholegraph: build wheels without build isolation #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Jan 20, 2026
Merged

libwholegraph: build wheels without build isolation #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc603a6
libwholegraph: build wheels without build isolation
jameslamb Jan 16, 2026
1b0cee7
fix needs blocks
jameslamb Jan 16, 2026
b213eb8
add cmake and ninja to 'requirements' outputs
jameslamb Jan 16, 2026
ea2064c
build cugraph-pyg on cpu4
jameslamb Jan 16, 2026
aaf62e4
Update ci/build_wheel.sh
jameslamb Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
branch: ${{ inputs.branch }}
sha: ${{ inputs.sha }}
date: ${{ inputs.date }}
node_type: cpu8
node_type: cpu4
Copy link
Contributor

@bdice bdice Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note: for some reason cpu4 has tended to queue for a long time in the past. I've been sticking to cpu8 at minimum. Not sure if this is still the case.

Copy link
Member Author

@jameslamb jameslamb Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, I didn't realize that. I was just thinking "small = cheap" and hadn't considered the queue.

I just checked and it looks like we allow up to 1000 cpu4 instances at a time (per CPU architecture... 1000 amd64 and 1000 arm64) and haven't come close to hitting that in the last 7 days. The 7-day max looks like around 800 busy runners, and the typical load is usually closer to like 350 busy at a time.

(can share dashboard links privately if you're curious)

So I think this change should be ok and hopefully shouldn't introduce new queuing problems.

script: ci/build_wheel_cugraph-pyg.sh
package-name: cugraph-pyg
package-type: python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ jobs:
# This selects "ARCH=amd64 + the latest supported Python + CUDA".
matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]))
build_type: pull-request
node_type: cpu8
node_type: cpu4
script: ci/build_wheel_cugraph-pyg.sh
package-name: cugraph-pyg
package-type: python
Expand Down
10 changes: 9 additions & 1 deletion ci/build_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,17 @@ RAPIDS_PIP_WHEEL_ARGS=(
-v
--no-deps
--disable-pip-version-check
--build-constraint="${PIP_CONSTRAINT}"
)

# Only use --build-constraint when build isolation is enabled.
#
# Passing '--build-constraint' and '--no-build-isolation` together results in an error from 'pip',
# but we want to keep environment variable PIP_CONSTRAINT set unconditionally.
# PIP_NO_BUILD_ISOLATION=0 means "add --no-build-isolation" (ref: https://github.com/pypa/pip/issues/5735)
if [[ "${PIP_NO_BUILD_ISOLATION:-}" != "0" ]]; then
RAPIDS_PIP_WHEEL_ARGS+=(--build-constraint="${PIP_CONSTRAINT}")
fi

# unset PIP_CONSTRAINT (set by rapids-init-pip)... it doesn't affect builds as of pip 25.3, and
# results in an error from 'pip wheel' when set and --build-constraint is also passed
unset PIP_CONSTRAINT
Expand Down
24 changes: 23 additions & 1 deletion ci/build_wheel_libwholegraph.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0

set -euo pipefail
Expand All @@ -8,7 +8,29 @@ source rapids-init-pip

package_dir="python/libwholegraph"

rapids-logger "Generating build requirements"
matrix_selectors="cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION};cuda_suffixed=true"

rapids-dependency-file-generator \
--output requirements \
--file-key "py_build_libwholegraph" \
--file-key "py_rapids_build_libwholegraph" \
--matrix "${matrix_selectors}" \
| tee /tmp/requirements-build.txt

rapids-logger "Installing build requirements"
rapids-pip-retry install \
-v \
--prefer-binary \
-r /tmp/requirements-build.txt

rapids-logger "Done installing build requirements"

export SKBUILD_CMAKE_ARGS="-DBUILD_SHARED_LIBS=ON;-DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE"

# build with '--no-build-isolation', for better sccache hit rate
# 0 really means "add --no-build-isolation" (ref: https://github.com/pypa/pip/issues/5735)
export PIP_NO_BUILD_ISOLATION=0

./ci/build_wheel.sh libwholegraph ${package_dir} cpp
./ci/validate_wheel.sh ${package_dir} "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}"
2 changes: 1 addition & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ dependencies:
- libcusparse-dev
common_build:
common:
- output_types: [conda, pyproject]
- output_types: [conda, pyproject, requirements]
packages:
- &cmake_ver cmake>=3.30.4
- ninja
Expand Down