Skip to content

libwholegraph: build wheels without build isolation#388

Merged
rapids-bot[bot] merged 5 commits intorapidsai:mainfrom
jameslamb:libwholegraph-build-isolation
Jan 20, 2026
Merged

libwholegraph: build wheels without build isolation#388
rapids-bot[bot] merged 5 commits intorapidsai:mainfrom
jameslamb:libwholegraph-build-isolation

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 16, 2026

Followup to #182, related to #386 (review)

Proposes using --no-build-isolation for libwholegraph wheel builds. --no-build-isolation preserves all of the source file paths, which should lead to better sccache hit rate and faster builds.

All of the other lib{something} wheels in RAPIDS are built this way, see rapidsai/build-planning#108

Also switches cugraph-pyg builds to smaller runners (cpu4). That's a pure-Python package that shouldn't need many resources to build.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 16, 2026
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 16, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

jobs:
pr-builder:
needs:
- check-nightly-ci
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a first run of only wheel builds, to test and to populate the cache.

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: libwholegraph: build wheels without build isolation libwholegraph: build wheels without build isolation Jan 16, 2026
@jameslamb jameslamb marked this pull request as ready for review January 16, 2026 23:02
@jameslamb jameslamb requested review from a team as code owners January 16, 2026 23:02
@greptile-apps

This comment was marked as off-topic.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
sha: ${{ inputs.sha }}
date: ${{ inputs.date }}
node_type: cpu8
node_type: cpu4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note: for some reason cpu4 has tended to queue for a long time in the past. I've been sticking to cpu8 at minimum. Not sure if this is still the case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, I didn't realize that. I was just thinking "small = cheap" and hadn't considered the queue.

I just checked and it looks like we allow up to 1000 cpu4 instances at a time (per CPU architecture... 1000 amd64 and 1000 arm64) and haven't come close to hitting that in the last 7 days. The 7-day max looks like around 800 busy runners, and the typical load is usually closer to like 350 busy at a time.

(can share dashboard links privately if you're curious)

So I think this change should be ok and hopefully shouldn't introduce new queuing problems.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b19c152 into rapidsai:main Jan 20, 2026
132 of 137 checks passed
@jameslamb jameslamb deleted the libwholegraph-build-isolation branch January 20, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants