Skip to content

WIP: Use pandas.util.testing #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: Use pandas.util.testing #6349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
- PR #6163 Use `Column.full` instead of `scalar_broadcast_to` or `cupy.zeros`
- PR #6176 Fix cmake warnings for GoogleTest, GoogleBenchmark, and Arrow external projects
- PR #6149 Update to Arrow v1.0.1
- PR #6349 Use `pandas.utils.testing`
- PR #6201 Expose libcudf test utilities headers for external project use.
- PR #6174 Data profile support in random data generator; Expand cuIO benchmarks
- PR #6189 Avoid deprecated pyarrow.compat for parquet
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/cudf/testing/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ def assert_frame_equal(
obj=f"{obj}.index",
)

pd.testing.assert_index_equal(
pd.util.testing.assert_index_equal(
left.columns,
right.columns,
exact=check_column_type,
Expand Down
14 changes: 7 additions & 7 deletions python/cudf/cudf/tests/test_testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def test_basic_assert_index_equal(

kind = None
try:
pd.testing.assert_index_equal(
pd.util.testing.assert_index_equal(
p_left,
p_right,
exact=exact,
Expand Down Expand Up @@ -90,7 +90,7 @@ def test_basic_assert_series_equal(

kind = None
try:
pd.testing.assert_series_equal(
pd.util.testing.assert_series_equal(
p_left,
p_right,
check_names=check_names,
Expand Down Expand Up @@ -157,7 +157,7 @@ def test_basic_assert_frame_equal(

kind = None
try:
pd.testing.assert_frame_equal(
pd.util.testing.assert_frame_equal(
p_left,
p_right,
check_exact=check_exact,
Expand Down Expand Up @@ -200,7 +200,7 @@ def test_datetime_like_compaibility(rdata, check_datetimelike_compat):

kind = None
try:
pd.testing.assert_series_equal(
pd.util.testing.assert_series_equal(
psr1, psr2, check_datetimelike_compat=check_datetimelike_compat
)
except BaseException as e:
Expand Down Expand Up @@ -235,7 +235,7 @@ def test_multiindex_equal(rdata):

kind = None
try:
pd.testing.assert_index_equal(pidx1, pidx2)
pd.util.testing.assert_index_equal(pidx1, pidx2)
except BaseException as e:
kind = type(e)

Expand All @@ -260,7 +260,7 @@ def test_series_different_type_cases(dtype, check_exact, check_dtype):

kind = None
try:
pd.testing.assert_series_equal(
pd.util.testing.assert_series_equal(
psr1, psr2, check_exact=check_exact, check_dtype=check_dtype
)
except BaseException as e:
Expand Down Expand Up @@ -290,7 +290,7 @@ def test_range_index_and_int_index_eqaulity(index, exact):

kind = None
try:
pd.testing.assert_index_equal(pidx1, pidx2, exact=exact)
pd.util.testing.assert_index_equal(pidx1, pidx2, exact=exact)
except BaseException as e:
kind = type(e)

Expand Down