Skip to content

WIP: Use pandas.util.testing #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: Use pandas.util.testing #6349

wants to merge 1 commit into from

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Sep 29, 2020 •
edited
Loading

pandas.testing is deprecated. The preferred way forward is to use pandas.util.testing. So this updates cuDF usage accordingly.

@jakirkham jakirkham added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Sep 29, 2020
@jakirkham jakirkham requested a review from a team as a code owner September 29, 2020 18:10
@jakirkham
Use pandas.util.testing
8d4e514 
`pandas.testing` is deprecated. The preferred way forward is to use
`pandas.util.testing`. So this updates cuDF usage accordingly.
@jakirkham jakirkham changed the title Use pandas.utils.testing Use pandas.util.testing Sep 29, 2020
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020 •
edited
Loading

Codecov Report

Merging #6349 into branch-0.16 will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #6349      +/-   ##
===============================================
+ Coverage        83.18%   83.21%   +0.03%     
===============================================
  Files               92       92              
  Lines            14729    14730       +1     
===============================================
+ Hits             12252    12258       +6     
+ Misses            2477     2472       -5
Impacted Files Coverage Δ
python/cudf/cudf/testing/testing.py 80.86% <100.00%> (ø)
python/cudf/cudf/testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 45.51% <0.00%> (+0.71%) ⬆️
python/cudf/cudf/core/abc.py 91.48% <0.00%> (+4.25%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 58.53% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c1c1c...8d4e514. Read the comment docs.

@jakirkham jakirkham marked this pull request as draft September 29, 2020 23:36
@jakirkham jakirkham changed the title Use pandas.util.testing WIP: Use pandas.util.testing Sep 29, 2020
@jakirkham jakirkham added 2 - In Progress Currently a work in progress and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels Sep 29, 2020
@jakirkham
Copy link
Member Author

Apologies. I got this backwards 🤦‍♂️

Replacing with PR ( #6357 ), which fixes this the right way 😅

@jakirkham jakirkham closed this Sep 29, 2020
@jakirkham jakirkham deleted the fix_pandas_testing branch September 29, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid isVoid approved these changes

Assignees

No one assigned

Labels

2 - In Progress Currently a work in progress Python Affects Python cuDF API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jakirkham @galipremsagar @isVoid @kkraus14