Build and test with CUDA 13.3.0 - #22825
Conversation
bdice
added
non-breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
Python
bdice
changed the title
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR upgrades CUDA support from 13.2 to 13.3 across the repository: dependency matrices, conda environment YAMLs, devcontainer configurations (conda & pip), CONTRIBUTING.md, and GitHub Actions reusable-workflow refs pinned to ChangesCUDA 13.3 version upgrade
🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Fixed merge conflicts, this is ready whenever CI passes.
|
/merge |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr.yaml:
- Line 787: In the cuml-compat-tests job within the workflow file, update the
rapidsai/shared-workflows reference to use the same version tag as all other
shared-workflow references in the file. Change the uses statement from using
`@main` to `@cuda-13.3.0` to maintain consistency with the other
rapidsai/shared-workflows/.github/workflows/custom-job.yaml references
throughout the file.
- Around line 791-793: The workflow is triggered by push events but passes
undefined `inputs.branch`, `inputs.date`, and `inputs.sha` values to the
custom-job.yaml workflow, since the inputs context is only available in
workflow_dispatch and workflow_call contexts. Replace `inputs.branch` with
`github.ref_name` for the branch reference and `inputs.sha` with `github.sha`
for the commit SHA across all four job instances that contain this pattern
(appearing at lines 770-772, 791-793, 812-814, and 831-833). For the date
parameter, determine an appropriate value or consider removing it if not
required by the called workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d1e302e5-22b0-4267-bb21-8bac10f360fb
📒 Files selected for processing (7)
.github/workflows/build.yaml.github/workflows/pr.yaml.github/workflows/test.yamlconda/environments/all_cuda-133_arch-aarch64.yamlconda/environments/all_cuda-133_arch-x86_64.yamldependencies.yamlpython/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml
✅ Files skipped from review due to trivial changes (1)
- conda/environments/all_cuda-133_arch-x86_64.yaml
🚧 Files skipped from review as they are similar to previous changes (5)
- conda/environments/all_cuda-133_arch-aarch64.yaml
- python/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml
- dependencies.yaml
- .github/workflows/test.yaml
- .github/workflows/build.yaml
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr.yaml:
- Line 787: In the cuml-compat-tests job within the workflow file, update the
rapidsai/shared-workflows reference to use the same version tag as all other
shared-workflow references in the file. Change the uses statement from using
`@main` to `@cuda-13.3.0` to maintain consistency with the other
rapidsai/shared-workflows/.github/workflows/custom-job.yaml references
throughout the file.
- Around line 791-793: The workflow is triggered by push events but passes
undefined `inputs.branch`, `inputs.date`, and `inputs.sha` values to the
custom-job.yaml workflow, since the inputs context is only available in
workflow_dispatch and workflow_call contexts. Replace `inputs.branch` with
`github.ref_name` for the branch reference and `inputs.sha` with `github.sha`
for the commit SHA across all four job instances that contain this pattern
(appearing at lines 770-772, 791-793, 812-814, and 831-833). For the date
parameter, determine an appropriate value or consider removing it if not
required by the called workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d1e302e5-22b0-4267-bb21-8bac10f360fb
📒 Files selected for processing (7)
.github/workflows/build.yaml.github/workflows/pr.yaml.github/workflows/test.yamlconda/environments/all_cuda-133_arch-aarch64.yamlconda/environments/all_cuda-133_arch-x86_64.yamldependencies.yamlpython/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml
✅ Files skipped from review due to trivial changes (1)
- conda/environments/all_cuda-133_arch-x86_64.yaml
🚧 Files skipped from review as they are similar to previous changes (5)
- conda/environments/all_cuda-133_arch-aarch64.yaml
- python/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml
- dependencies.yaml
- .github/workflows/test.yaml
- .github/workflows/build.yaml
🛑 Comments failed to post (2)
.github/workflows/pr.yaml (2)
787-787:
⚠️ Potential issue | 🟠 Major🧩 Analysis chain
🏁 Script executed:
#!/bin/bash # Verify all shared-workflows refs in this workflow file. # Expected for this migration PR: no remaining `@main` refs in .github/workflows/pr.yaml. rg -n 'uses:\s*rapidsai/shared-workflows/.+@' .github/workflows/pr.yaml rg -n 'uses:\s*rapidsai/shared-workflows/.+@main' .github/workflows/pr.yamlRepository: rapidsai/cudf
Length of output: 2968
Line 787 still uses
@main, breaking this PR's workflow-ref consistency.All other
rapidsai/shared-workflowsreferences in the file use@cuda-13.3.0, but thiscuml-compat-testsjob references@main.Suggested fix
- uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@cuda-13.3.0📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@cuda-13.3.0🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/pr.yaml at line 787, In the cuml-compat-tests job within the workflow file, update the rapidsai/shared-workflows reference to use the same version tag as all other shared-workflow references in the file. Change the uses statement from using `@main` to `@cuda-13.3.0` to maintain consistency with the other rapidsai/shared-workflows/.github/workflows/custom-job.yaml references throughout the file.Source: Learnings
791-793:
⚠️ Potential issue | 🟠 Major🧩 Analysis chain
🏁 Script executed:
#!/bin/bash # Verify whether branch/date/sha are declared as workflow inputs and where they are used. # Expected: these keys exist under on.workflow_call.inputs or on.workflow_dispatch.inputs # if referenced via ${{ inputs.* }}. rg -n -C3 '^\s*on:|workflow_call:|workflow_dispatch:|^\s*inputs:' .github/workflows/pr.yaml rg -n -C2 '\${{\s*inputs\.(branch|date|sha)\s*}}' .github/workflows/pr.yamlRepository: rapidsai/cudf
Length of output: 273
🏁 Script executed:
#!/bin/bash # Get the file size first wc -l .github/workflows/pr.yaml # Read lines around 791-793 sed -n '780,800p' .github/workflows/pr.yaml # Search for inputs references using corrected syntax (no backslash escaping needed) rg -n 'inputs\.(branch|date|sha)' .github/workflows/pr.yaml # Check workflow trigger configuration sed -n '1,50p' .github/workflows/pr.yamlRepository: rapidsai/cudf
Length of output: 2649
🏁 Script executed:
#!/bin/bash # Check for workflow_dispatch and input definitions sed -n '1,100p' .github/workflows/pr.yaml | grep -n -A 30 '^on:' # Get more context around lines 791-793 to identify the job sed -n '770,810p' .github/workflows/pr.yaml | cat -n # Search for input definitions in the entire file rg -n 'workflow_dispatch|inputs:' .github/workflows/pr.yaml | head -20Repository: rapidsai/cudf
Length of output: 2960
🏁 Script executed:
#!/bin/bash # Search for where branch, date, sha might be defined as job outputs rg -n -B3 'outputs:' .github/workflows/pr.yaml | head -40 # Search for env variables or other sources for these values rg -n 'branch|date|sha' .github/workflows/pr.yaml | grep -E '(outputs|env|github\.)' | head -20Repository: rapidsai/cudf
Length of output: 230
🏁 Script executed:
#!/bin/bash # Look for where branch/date/sha should actually come from # Check for github context usage rg -n 'github\.(event|ref|sha)' .github/workflows/pr.yaml | head -20 # Check for step outputs that might define these rg -n 'outputs\.' .github/workflows/pr.yaml | grep -E '(branch|date|sha)' # Get full context of one complete job that passes branch/date/sha sed -n '755,820p' .github/workflows/pr.yaml | cat -nRepository: rapidsai/cudf
Length of output: 3511
Lines 791-793 and similar lines pass undefined
inputs.*values to the called workflow.This workflow is push-triggered (
on: push:), which does not provide theinputs.*context. Theinputs.branch,inputs.date, andinputs.shavariables are only available inworkflow_dispatchandworkflow_callcontexts. These values will be empty when passed tocustom-job.yaml@cuda-13.3.0, causing the called workflow to receive null/undefined parameters. This pattern appears in at least four jobs (lines 770-772, 791-793, 812-814, 831-833).Consider using
github.ref_namefor branch andgithub.shafor sha, or adding aworkflow_dispatchtrigger with proper input definitions if manual overrides are needed.🧰 Tools
🪛 actionlint (1.7.12)
[error] 791-791: property "branch" is not defined in object type {}
(expression)
[error] 792-792: property "date" is not defined in object type {}
(expression)
[error] 793-793: property "sha" is not defined in object type {}
(expression)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/pr.yaml around lines 791 - 793, The workflow is triggered by push events but passes undefined `inputs.branch`, `inputs.date`, and `inputs.sha` values to the custom-job.yaml workflow, since the inputs context is only available in workflow_dispatch and workflow_call contexts. Replace `inputs.branch` with `github.ref_name` for the branch reference and `inputs.sha` with `github.sha` for the commit SHA across all four job instances that contain this pattern (appearing at lines 770-772, 791-793, 812-814, and 831-833). For the date parameter, determine an appropriate value or consider removing it if not required by the called workflow.Source: Linters/SAST tools
Contributes to rapidsai/build-planning#286 * uses CUDA 13.3.0 to build and test * updates to CUDA 13.3.0 devcontainers ## Notes for Reviewers This switches GitHub Actions workflows to the `cuda-13.3.0` branch from here: rapidsai/shared-workflows#574 A future round of PRs will revert that back to `main`, once all of RAPIDS is migrated. Authors: - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) - Gil Forsyth (https://github.com/gforsyth) - Lawrence Mitchell (https://github.com/wence-) - David Wendt (https://github.com/davidwendt) Approvers: - James Lamb (https://github.com/jameslamb) URL: NVIDIA#22825
6 participants
Contributes to rapidsai/build-planning#286
Notes for Reviewers
This switches GitHub Actions workflows to the
cuda-13.3.0branch from here: rapidsai/shared-workflows#574A future round of PRs will revert that back to
main, once all of RAPIDS is migrated.