Update CuPy and NumPy dependency specs - #22962
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates CuPy and NumPy version constraints across dependency matrices, Python package manifests, conda recipes, and generated CUDA environment files. Some package and recipe headers also change to include “NVIDIA CORPORATION & AFFILIATES”. ChangesCuPy 14 and NumPy 2 Dependency Bump
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dependencies.yaml`:
- Around line 1060-1073: The test CuPy wheel pins in the dependency matrices
still use plain cupy-cuda12x and cupy-cuda13x, which is inconsistent with the
canonical depends_on_cupy entries that require the [ctk] selector. Update the
affected matrix package entries in dependencies.yaml to use the same [ctk]
contract as depends_on_cupy so test and production dependency resolution stay
aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 526ee758-902a-45ff-baa5-e39c036693d7
📒 Files selected for processing (1)
dependencies.yaml
mroeschke
left a comment
There was a problem hiding this comment.
(Reminding myself that are some CI/code cleanups available once this merged)
jameslamb
left a comment
There was a problem hiding this comment.
Changes look right to me, though there are what look like real failures in the oldest-deps jobs:
Attribute "dtype" are different
[left]: int64
[right]: float64
FAILED tests/dataframe/test_np_ufuncs.py::test_ufunc_dataframe[ceil-False-False] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="foo") are different
Attribute "dtype" are different
[left]: int64
[right]: float64
FAILED tests/dataframe/test_np_ufuncs.py::test_ufunc_dataframe[floor-True-False] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="foo") are different
|
Ok, so previously, It seems like I don't think this is a new failure, so much as one that hasn't shown up yet because we haven't tested on 2.0.*. What if we bump the lower bound of I can reproduce this locally if On other PRs without the dependency changes proposed here, the
|
`cupy>=14` and `numpy>=2.1` have unified behavior around casting integers and booleans to floats (they don't do it). This leaves us with a condition where numpy>2,<2.1 where the two libraries mismatch on their behavior. These get xfailed.
| and parse(np.__version__) >= parse("2.0") | ||
| and parse(np.__version__) < parse("2.1"), |
There was a problem hiding this comment.
Now that we are using cupy>=14, which has unified casting behavior with numpy>=2.1, we only need to xfail these tests when numpy>=2.0,<2.1
| and parse(np.__version__) >= parse("2.0") | ||
| and parse(np.__version__) < parse("2.1"), |
There was a problem hiding this comment.
Now that we are using cupy>=14, which has unified casting behavior with numpy>=2.1, we only need to xfail these tests when numpy>=2.0,<2.1
|
/merge |
Follow up to #22962 Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Bradley Dice (https://github.com/bdice) URL: #23053
Contributes to rapidsai/build-planning#279
RAPIDS is taking on requirements
cupy>=14.0.1,!=14.1.0andnumpy>=2.0. Wheel dependencies oncupy-cuda12xandcupy-cuda13xnow use the[ctk]extra.See the linked issue for details.