Skip to content

Split PR devcontainer CI into pip and conda jobs - #22490

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
bdice:split-devcontainers-pip-conda
May 13, 2026
Merged

Split PR devcontainer CI into pip and conda jobs#22490
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
bdice:split-devcontainers-pip-conda

Conversation

@bdice

@bdice bdice commented May 13, 2026

Copy link
Copy Markdown
Contributor

Description

Split the PR workflow devcontainer build into two jobs, devcontainers-conda and devcontainers-pip, by passing python_package_manager as ["conda"] or ["pip"] to build-in-devcontainer.yaml. pr-builder depends only on devcontainers-conda; devcontainers-pip is added to checks ignored_pr_jobs so it does not block merge. Shared permissions and build_command are deduplicated with YAML anchors (merge keys are avoided so zizmor can validate the workflow); devcontainers-conda is listed first in the workflow file.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Use build-in-devcontainer python_package_manager for each variant; require
devcontainers-conda in pr-builder and ignore devcontainers-pip for dependency checks.
@bdice
bdice requested a review from a team as a code owner May 13, 2026 14:52
@bdice
bdice requested a review from gforsyth May 13, 2026 14:53
@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 07e1d89e-98dd-4051-b35a-d17b34eb502f

📥 Commits

Reviewing files that changed from the base of the PR and between 1ffb236 and a3a2576.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/pr.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow to support testing across multiple Python package managers, expanding test coverage.

Walkthrough

Split the single devcontainer workflow job into devcontainers-conda and devcontainers-pip, extract a shared build_command anchor used by both, update pr-builder.needs to devcontainers-conda, and add devcontainers-pip to checks.with.ignored_pr_jobs.

Changes

Devcontainer Job Separation

Layer / File(s) Summary
Define conda and pip devcontainer jobs
.github/workflows/pr.yaml
Adds devcontainers-conda (with python_package_manager: ["conda"]) and devcontainers-pip (with python_package_manager: ["pip"]), and extracts a shared &devcontainers-build-command anchor referenced by both jobs.
Update job dependency and ignore list
.github/workflows/pr.yaml
Updates jobs.pr-builder.needs to depend on devcontainers-conda and extends jobs.checks.with.ignored_pr_jobs to include devcontainers-pip.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely summarizes the main change: splitting the devcontainer CI job into separate pip and conda jobs, which matches the core objective of the changeset.
Description check ✅ Passed The description thoroughly explains the changes, including the rationale for splitting jobs, how each job is configured, dependency management, and technical implementation details using YAML anchors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 13, 2026
@bdice

bdice commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit ff37ba8 into NVIDIA:main May 13, 2026
118 of 120 checks passed
rapids-bot Bot pushed a commit that referenced this pull request May 13, 2026
…22497)

Reverts #22490 now that upstream issues breaking pip devcontainers are fixed in cuCascade and rapidsmpf.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #22497
@coderabbitai coderabbitai Bot mentioned this pull request Jun 16, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants