Skip to content

Adjust cudf-polars test timeouts - #22691

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
TomAugspurger:tom/cudf-polars-timeout-tuning
May 28, 2026
Merged

Adjust cudf-polars test timeouts#22691
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
TomAugspurger:tom/cudf-polars-timeout-tuning

Conversation

@TomAugspurger

Copy link
Copy Markdown
Contributor

@TomAugspurger
TomAugspurger requested review from a team as code owners May 28, 2026 12:00
@TomAugspurger TomAugspurger added the cudf-polars Issues specific to cudf-polars label May 28, 2026
@github-actions github-actions Bot added the Python Affects Python cuDF API. label May 28, 2026
@TomAugspurger TomAugspurger added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 28, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python May 28, 2026
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8ea704cb-7f40-4328-af36-0c9ff83de3bb

📥 Commits

Reviewing files that changed from the base of the PR and between 1174c77 and c2735d2.

📒 Files selected for processing (2)
  • ci/test_wheel_cudf_polars.sh
  • python/cudf_polars/tests/streaming/test_scan.py

📝 Walkthrough

Summary by CodeRabbit

  • Tests

    • Added explicit timeout enforcement for parallel scan test execution.
  • Chores

    • Increased timeout allowance for Polars wheel test suite, enabling longer per-version test runs to improve test reliability and reduce premature timeouts.

Walkthrough

This PR increases timeout limits for cudf-polars test execution at two levels: the CI script timeout for wheel tests is extended from 25 minutes to 35 minutes, and a specific parallel scan test is decorated with a 90-second individual test timeout.

Changes

Timeout adjustments for cudf-polars test suite

Layer / File(s) Summary
CI execution timeout adjustment
ci/test_wheel_cudf_polars.sh
The timeout for ./ci/run_cudf_polars_pytests.sh invocation increased from 25m to 35m to allow longer per-version test runs.
Test-level timeout enforcement
python/cudf_polars/tests/streaming/test_scan.py
test_parallel_scan decorated with pytest.mark.timeout(90) to enforce 90-second runtime limit on that test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cudf#22505: Both PRs adjust the ci/test_wheel_cudf_polars.sh ./ci/run_cudf_polars_pytests.sh invocation timeout, directly touching the same script call.
  • rapidsai/cudf#22543: Both PRs modify cudf-polars pytest test execution to adjust timeout behavior for the same test suite.

Suggested labels

Python, improvement, non-breaking, cudf-polars

Suggested reviewers

  • jameslamb
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Adjust cudf-polars test timeouts' accurately summarizes the main changes: adjusting timeouts for both a specific test and the overall CI job.
Description check ✅ Passed The description clearly relates to the changeset by explaining why timeout adjustments were made and referencing specific failing CI runs that motivated each change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 7a9a1db into NVIDIA:main May 28, 2026
206 of 208 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python May 28, 2026
@TomAugspurger
TomAugspurger deleted the tom/cudf-polars-timeout-tuning branch May 28, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf-polars Issues specific to cudf-polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants