ci: reduce timeout for cudf_streaming C++ tests to 5m - #22880
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe CI test script ChangesCI streaming tests timeout adjustment
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The cudf_streaming tests are lightweight and complete quickly. Reduce the timeout from 30m to 5m which still provides ample headroom while avoiding masking long hangs. References: - NVIDIA#22747 (comment) - NVIDIA#22747 (comment) Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
vyasr
force-pushed
the
drop-cudf-streaming-timeouts
branch
from
June 13, 2026 00:29
22c2a7e to
518eb66
Compare
10 tasks
Contributor
Author
|
FYI @bdice @pentschev |
bdice
approved these changes
Jun 13, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the
timeoutforcudf_streamingC++ tests from 30m to 5m inci/test_cpp.sh.The cudf_streaming tests are lightweight and complete quickly. The 30m timeout was kept during the initial PR (#22747) out of caution after reviewer feedback (#22747 (comment), #22747 (comment)), but 5m provides ample headroom while catching hangs much sooner.
Checklist