Skip to content

ci: reduce timeout for cudf_streaming C++ tests to 5m - #22880

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
vyasr:drop-cudf-streaming-timeouts
Jun 13, 2026
Merged

ci: reduce timeout for cudf_streaming C++ tests to 5m#22880
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
vyasr:drop-cudf-streaming-timeouts

Conversation

@vyasr

@vyasr vyasr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Description

Reduce the timeout for cudf_streaming C++ tests from 30m to 5m in ci/test_cpp.sh.

The cudf_streaming tests are lightweight and complete quickly. The 30m timeout was kept during the initial PR (#22747) out of caution after reviewer feedback (#22747 (comment), #22747 (comment)), but 5m provides ample headroom while catching hangs much sooner.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner June 13, 2026 00:15
@vyasr
vyasr requested a review from msarahan June 13, 2026 00:15
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 90cec12d-2327-475c-bc6d-3a734426e26b

📥 Commits

Reviewing files that changed from the base of the PR and between 22c2a7e and 518eb66.

📒 Files selected for processing (1)
  • ci/test_cpp.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Reduced the CI timeout for libcudf streaming C++ tests from 30 minutes to 5 minutes. This yields faster feedback on long-running streaming tests but may cause earlier test termination for suites that exceed the new limit.

Walkthrough

The CI test script ci/test_cpp.sh changes the libcudf streaming gtests invocation from timeout 30m ./ci/run_cudf_streaming_ctests.sh -j20 to timeout 5m ./ci/run_cudf_streaming_ctests.sh -j20, shortening the allowed execution time.

Changes

CI streaming tests timeout adjustment

Layer / File(s) Summary
Update streaming ctests timeout to 5m
ci/test_cpp.sh
Replaces timeout 30m with timeout 5m for ./ci/run_cudf_streaming_ctests.sh -j20 in the CI test script.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

libcudf

Suggested reviewers

  • bdice
  • PointKernel
  • pentschev
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reducing the timeout for cudf_streaming C++ tests from 30 minutes to 5 minutes in the CI configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for reducing the timeout, referencing prior discussions, and confirming test coverage and documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 13, 2026
The cudf_streaming tests are lightweight and complete quickly. Reduce
the timeout from 30m to 5m which still provides ample headroom while
avoiding masking long hangs.

References:
- NVIDIA#22747 (comment)
- NVIDIA#22747 (comment)

Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
@vyasr
vyasr force-pushed the drop-cudf-streaming-timeouts branch from 22c2a7e to 518eb66 Compare June 13, 2026 00:29
@vyasr vyasr changed the title ci: drop timeout for cudf_streaming C++ tests ci: reduce timeout for cudf_streaming C++ tests to 5m Jun 13, 2026
@vyasr

vyasr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

FYI @bdice @pentschev

@vyasr

vyasr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit d36bfd3 into NVIDIA:main Jun 13, 2026
115 of 116 checks passed
@vyasr
vyasr deleted the drop-cudf-streaming-timeouts branch June 13, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants