Skip to content

Increase timeouts for slower cudf-polars tests - #22780

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
TomAugspurger:tom/cudf-polars-timeout-adjustments-2
Jun 4, 2026
Merged

Increase timeouts for slower cudf-polars tests#22780
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
TomAugspurger:tom/cudf-polars-timeout-adjustments-2

Conversation

@TomAugspurger

Copy link
Copy Markdown
Contributor

Description

https://github.com/rapidsai/cudf/actions/runs/26937471348/job/79470587366 contains a couple of failures. There are some pytest internal errors so I think we don't get the whole traceback, but at least some look related to timeouts in the tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

https://github.com/rapidsai/cudf/actions/runs/26937471348/job/79470587366
contains a couple of failures. There are some pytest internal errors so
I think we don't get the whole traceback, but at least some look related
to timeouts in the tests.
@TomAugspurger
TomAugspurger requested a review from a team as a code owner June 4, 2026 11:29
@TomAugspurger
TomAugspurger requested a review from rjzamora June 4, 2026 11:29
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Jun 4, 2026
@TomAugspurger TomAugspurger added non-breaking Non-breaking change bug Something isn't working labels Jun 4, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python Jun 4, 2026
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 35dc9759-52a9-457a-bc63-478574f91990

📥 Commits

Reviewing files that changed from the base of the PR and between 3e66fd6 and 8ad967f.

📒 Files selected for processing (2)
  • python/cudf_polars/tests/expressions/test_rolling.py
  • python/cudf_polars/tests/streaming/test_sort.py

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Added execution timeout limits to tests to ensure timely completion and improve test suite reliability.

Walkthrough

This PR adds pytest timeout decorators to two test functions in the cudf-polars test suite to enforce 120-second execution limits on potentially long-running tests.

Changes

Test timeout enforcement

Layer / File(s) Summary
Add timeout decorators to tests
python/cudf_polars/tests/expressions/test_rolling.py, python/cudf_polars/tests/streaming/test_sort.py
@pytest.mark.timeout(120) decorators are added to test_rank_over_with_null_group_keys and test_sort test functions to cap execution time at 120 seconds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/cudf#22691: Both PRs adjust pytest timeout decorators for cudf-polars Python tests; the related PR also adds timeouts to test_parallel_scan and CI job runtime configuration.
  • rapidsai/cudf#22543: The related PR configures pytest-timeout for the overall test suite; this PR applies per-test timeout markers that leverage that plugin.

Suggested labels

improvement

Suggested reviewers

  • gforsyth
  • jameslamb
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding timeout decorators to slower cudf-polars tests.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (CI failures due to timeouts) and providing context for the timeout increases.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit fc2ba0e into NVIDIA:main Jun 4, 2026
89 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants