Skip to content

Revert "Temporarily WAR rapidsmpf<->libcudf conda package build cycle (#22520)" - #22523

Closed
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:revert_rapidsmpf_conda_workaround
Closed

Revert "Temporarily WAR rapidsmpf<->libcudf conda package build cycle (#22520)"#22523
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:revert_rapidsmpf_conda_workaround

Conversation

@gforsyth

Copy link
Copy Markdown
Contributor

Reverts #22520 which temporarily disabled the import smoketest for the cudf-polars package so we could get around the circular dependency with rapidsmpf. Leaving this as a draft for now -- can be merged in after there are rapidsmpf conda packages for 26.08

@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 15, 2026
@copy-pr-bot

copy-pr-bot Bot commented May 15, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gforsyth
gforsyth marked this pull request as ready for review May 15, 2026 15:27
@gforsyth
gforsyth requested a review from a team as a code owner May 15, 2026 15:27
@gforsyth
gforsyth requested a review from KyleFromNVIDIA May 15, 2026 15:27
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d6ce21ff-7a52-46ab-8765-bd3fa5d53cc5

📥 Commits

Reviewing files that changed from the base of the PR and between 7a1bb07 and 5d780c9.

📒 Files selected for processing (1)
  • conda/recipes/cudf-polars/recipe.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Activated package validation tests in the conda recipe to ensure proper installation and functionality, including version verification and compatibility checks with the Polars library.

Walkthrough

The conda recipe for cudf-polars re-enables its tests section with package import validation, version checks under different initialization-disabling environment variables, and basic runtime smoke tests combining cudf_polars and polars functionality.

Changes

Conda Recipe Tests

Layer / File(s) Summary
cudf-polars test configuration
conda/recipes/cudf-polars/recipe.yaml
Conda recipe tests block is re-enabled with cudf_polars import check, version verification under initialization-disabling environment variables (RAPIDS_NO_INITIALIZE and CUDF_NO_INITIALIZE), and a smoke test that imports cudf_polars and uses polars to create a simple pl.Series.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cudf#22520: Disables the same tests section in the conda recipe for cudf-polars to address a build cycle; this PR re-activates those tests.

Suggested reviewers

  • jameslamb
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reverting a temporary workaround for a conda package build cycle issue, which aligns with re-enabling the tests in the recipe file.
Description check ✅ Passed The description directly relates to the changeset by explaining the revert of PR #22520 and the restoration of the import smoketest, matching the changes shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@vyasr

vyasr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Closing now that we've removed the circular dependency altogether.

@vyasr vyasr closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants