Skip to content

Test shared-workflows GPU matrix branch - #22991

Closed
bdice wants to merge 1 commit into
mainfrom
test-shared-workflows-gpu-matrix
Closed

Test shared-workflows GPU matrix branch#22991
bdice wants to merge 1 commit into
mainfrom
test-shared-workflows-gpu-matrix

Conversation

@bdice

@bdice bdice commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Test rapidsai/shared-workflows#582 in cuDF PR CI by pointing .github/workflows/pr.yaml at rapidsai/shared-workflows@gpu-runner-matrix-update.

Notes

This PR is for validating the shared-workflows GPU test matrix changes before merging them.

@bdice
bdice requested a review from a team as a code owner June 25, 2026 16:18
@bdice
bdice requested a review from KyleFromNVIDIA June 25, 2026 16:18
@bdice
bdice marked this pull request as draft June 25, 2026 16:20
@copy-pr-bot

copy-pr-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the PR validation workflow to use newer shared automation across build, test, docs, and wheel jobs.
    • This should help keep CI runs aligned with the latest orchestration updates and improve consistency across checks.

Walkthrough

GitHub Actions jobs in .github/workflows/pr.yaml now reference @gpu-runner-matrix-update instead of @main across PR orchestration, conda, docs, wheel, devcontainer, and integration workflows.

Changes

Reusable workflow ref updates

Layer / File(s) Summary
PR orchestration jobs
.github/workflows/pr.yaml
pr-builder and changed-files switch their reusable workflow refs from @main to @gpu-runner-matrix-update.
Core CI jobs
.github/workflows/pr.yaml
checks, conda-cpp, and conda-python jobs switch their reusable workflow refs from @main to @gpu-runner-matrix-update.
Conda docs jobs
.github/workflows/pr.yaml
conda-java-tests, conda-notebook-tests, and docs-build switch their reusable workflow refs from @main to @gpu-runner-matrix-update.
Wheel and container jobs
.github/workflows/pr.yaml
libcudf, cudf, cudf-polars, dask-cudf, pylibcudf, and devcontainer jobs switch their reusable workflow refs from @main to @gpu-runner-matrix-update.
Python integration jobs
.github/workflows/pr.yaml
unit-tests-cudf-pandas, third-party-integration-tests-cudf-pandas, cuml-compat-tests, pandas-tests, and narwhals-tests switch their reusable workflow refs from @main to @gpu-runner-matrix-update.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • rapidsai/cudf#22490: Also updates uses: references in .github/workflows/pr.yaml, including the devcontainer-related jobs.
  • rapidsai/cudf#22960: Changes the same reusable workflow call sites in .github/workflows/pr.yaml, but from a different pinned ref.

Suggested labels

improvement, non-breaking

Suggested reviewers

  • msarahan
  • jameslamb
  • gforsyth
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the PR is testing the shared-workflows GPU matrix branch.
Description check ✅ Passed The description directly explains the workflow change and its validation purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-shared-workflows-gpu-matrix

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/pr.yaml:
- Line 47: All shared-workflows uses refs in .github/workflows/pr.yaml still
point at the temporary gpu-runner-matrix-update branch; revert every changed
uses target back to `@main` before merge. Update the workflow entries consistently
across all affected jobs, using the existing shared-workflows workflow names
(for example pr-builder.yaml and the other shared-workflows calls in this file),
so no mutable feature-branch refs remain on main.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6deaeb7a-6d66-477c-854c-aeef011e83ce

📥 Commits

Reviewing files that changed from the base of the PR and between 14e9e9c and 4d5500a.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml

Comment thread .github/workflows/pr.yaml
- telemetry-setup
- third-party-integration-tests-cudf-pandas
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@gpu-runner-matrix-update

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Revert @gpu-runner-matrix-update refs to @main before merging.

Per the PR objectives, pointing every shared-workflows uses: ref at the gpu-runner-matrix-update branch is a temporary measure to validate rapidsai/shared-workflows#582 in cuDF CI. This branch is mutable and will likely be deleted once #582 merges, which would break cuDF PR CI if this state lands on main. Ensure all ~30 occurrences are reverted to @main before this PR is merged.

Note: SHA pinning is intentionally not required here since rapidsai/shared-workflows is RAPIDS-maintained; the only concern is the temporary feature-branch ref.

This applies to every changed uses: line in this file, including Lines 47, 88, 345, 358, 372, 388, 400, 413, 427, 442, 456, 471, 487, 504, 521, 538, 556, 574, 592, 606, 624, 642, 656, 675, 692, 708, 727, 744, 767, 783, 804, 825, and 844.

Want me to open a tracking issue so this revert isn't forgotten before merge?

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/pr.yaml at line 47, All shared-workflows uses refs in
.github/workflows/pr.yaml still point at the temporary gpu-runner-matrix-update
branch; revert every changed uses target back to `@main` before merge. Update the
workflow entries consistently across all affected jobs, using the existing
shared-workflows workflow names (for example pr-builder.yaml and the other
shared-workflows calls in this file), so no mutable feature-branch refs remain
on main.

Source: Learnings

@vyasr

vyasr commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Closing since rapidsai/shared-workflows#582 is merged.

@vyasr vyasr closed this Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants