Test shared-workflows GPU matrix branch - #22991
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughGitHub Actions jobs in ChangesReusable workflow ref updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr.yaml:
- Line 47: All shared-workflows uses refs in .github/workflows/pr.yaml still
point at the temporary gpu-runner-matrix-update branch; revert every changed
uses target back to `@main` before merge. Update the workflow entries consistently
across all affected jobs, using the existing shared-workflows workflow names
(for example pr-builder.yaml and the other shared-workflows calls in this file),
so no mutable feature-branch refs remain on main.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6deaeb7a-6d66-477c-854c-aeef011e83ce
📒 Files selected for processing (1)
.github/workflows/pr.yaml
| - telemetry-setup | ||
| - third-party-integration-tests-cudf-pandas | ||
| uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main | ||
| uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@gpu-runner-matrix-update |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Revert @gpu-runner-matrix-update refs to @main before merging.
Per the PR objectives, pointing every shared-workflows uses: ref at the gpu-runner-matrix-update branch is a temporary measure to validate rapidsai/shared-workflows#582 in cuDF CI. This branch is mutable and will likely be deleted once #582 merges, which would break cuDF PR CI if this state lands on main. Ensure all ~30 occurrences are reverted to @main before this PR is merged.
Note: SHA pinning is intentionally not required here since rapidsai/shared-workflows is RAPIDS-maintained; the only concern is the temporary feature-branch ref.
This applies to every changed uses: line in this file, including Lines 47, 88, 345, 358, 372, 388, 400, 413, 427, 442, 456, 471, 487, 504, 521, 538, 556, 574, 592, 606, 624, 642, 656, 675, 692, 708, 727, 744, 767, 783, 804, 825, and 844.
Want me to open a tracking issue so this revert isn't forgotten before merge?
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/pr.yaml at line 47, All shared-workflows uses refs in
.github/workflows/pr.yaml still point at the temporary gpu-runner-matrix-update
branch; revert every changed uses target back to `@main` before merge. Update the
workflow entries consistently across all affected jobs, using the existing
shared-workflows workflow names (for example pr-builder.yaml and the other
shared-workflows calls in this file), so no mutable feature-branch refs remain
on main.
Source: Learnings
|
Closing since rapidsai/shared-workflows#582 is merged. |
Summary
Test rapidsai/shared-workflows#582 in cuDF PR CI by pointing
.github/workflows/pr.yamlatrapidsai/shared-workflows@gpu-runner-matrix-update.Notes
This PR is for validating the shared-workflows GPU test matrix changes before merging them.